Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/proxy/proxy_info.h

Issue 473513002: Keep track of network error in ProxyRetryInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments by rsleevi - 2 Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/base/network_delegate.h ('K') | « net/http/http_stream_factory_impl_job.cc ('k') | net/proxy/proxy_info.cc » ('j') | net/proxy/proxy_list.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_info.h
diff --git a/net/proxy/proxy_info.h b/net/proxy/proxy_info.h
index 336cb3a58881c2982f4d1a4b4d10d5e16597cdf7..db1eb33798bf4b3ed45ef924696fcd0eea3391f3 100644
--- a/net/proxy/proxy_info.h
+++ b/net/proxy/proxy_info.h
@@ -117,7 +117,7 @@ class NET_EXPORT ProxyInfo {
// Marks the current proxy as bad. Returns true if there is another proxy
// available to try in proxy list_.
Ryan Sleevi 2014/08/15 18:02:36 Update comment :)
Not at Google. Contact bengr 2014/08/15 19:56:53 Done.
- bool Fallback(const BoundNetLog& net_log);
+ bool Fallback(int net_error, const BoundNetLog& net_log);
// De-prioritizes the proxies that we have cached as not working, by moving
// them to the end of the proxy list.
« net/base/network_delegate.h ('K') | « net/http/http_stream_factory_impl_job.cc ('k') | net/proxy/proxy_info.cc » ('j') | net/proxy/proxy_list.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698