Remove virtual/softwarecompositing suite

Remove virtual/softwarecompositing suite

Layout tests shouldn't be used to test compositor features.  The cc
pixel tests already include a large number of pixel tests for non-GPU
composited output that cover the set of cases that are required.

Additionally, non-gpu canvas is already tested via the fast/canvas
non-virtual suite.

R=abarth@chromium.org,senorblanco@chromium.org
BUG=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180387

[Stephen White, 2014-08-13 18:51:24]

rsLGTM

Should we also update the bugs referenced from TestExpectations to point to (or
suggest) cc tests instead
of layout tests? Or close them?

[abarth-chromium, 2014-08-13 18:59:03]

lgtm

[enne (OOO), 2014-08-13 19:15:06]

On 2014/08/13 at 18:51:24, senorblanco wrote:
> rsLGTM
> 
> Should we also update the bugs referenced from TestExpectations to point to
(or suggest) cc tests instead
> of layout tests? Or close them?

I was going to close them.

I haven't looked through them all, but they seem to fall into categories like:
(1) Bugs that affect software/hardware equally, e.g. http://crbug.com/240374
(2) Bugs that have slight software rendering differences (possibly flaky), e.g.
http://crbug.com/383205 (bug not helpful, but the comment in TestExpectations
says this)

The cc tests don't really map well to the layout tests.  In particular, the cc
pixel tests are testing the far end of the pipeline where we have a few
different quad types and a smaller set of quad input parameters and making sure
those raster correctly.

[enne (OOO), 2014-08-13 19:21:42]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2014-08-13 19:22:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/enne@chromium.org/473473003/1

[Stephen White, 2014-08-13 19:23:36]

On 2014/08/13 19:15:06, enne wrote:
> On 2014/08/13 at 18:51:24, senorblanco wrote:
> > rsLGTM
> > 
> > Should we also update the bugs referenced from TestExpectations to point to
> (or suggest) cc tests instead
> > of layout tests? Or close them?
> 
> I was going to close them.
> 
> I haven't looked through them all, but they seem to fall into categories like:
> (1) Bugs that affect software/hardware equally, e.g. http://crbug.com/240374
> (2) Bugs that have slight software rendering differences (possibly flaky),
e.g.
> http://crbug.com/383205 (bug not helpful, but the comment in TestExpectations
> says this)
> 
> The cc tests don't really map well to the layout tests.  In particular, the cc
> pixel tests are testing the far end of the pipeline where we have a few
> different quad types and a smaller set of quad input parameters and making
sure
> those raster correctly.

Sounds reasonable. Thanks for the explanation.

[commit-bot: I haz the power, 2014-08-13 23:40:45]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_db...)
  android_blink_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_re...)
  android_chromium_gn_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_comp...)
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/2...)
  linux_chromium_gn_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/19727)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[commit-bot: I haz the power, 2014-08-13 23:53:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-13 23:53:15]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/19745)

[enne (OOO), 2014-08-14 00:56:22]

abarth: Mind taking one more quick look at this change below? I'm not super
familiar with these tests.

https://codereview.chromium.org/473473003/diff/10001/Tools/Scripts/webkitpy/c...
File Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py
(right):

https://codereview.chromium.org/473473003/diff/10001/Tools/Scripts/webkitpy/c...
Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:131:
self.assertEqual(sorted(baseline_optimizer._files_to_delete),
sorted(expected_files_to_delete))
Other than search and replacing softwarecompositing => gpu/fast/canvas and
compositing => fast/canvas, this was the only other change I had to make to get
these tests passing.

I think this is legit.  files_to_delete sounds like an unordered list, so should
be sorted first before being compared.

[enne (OOO), 2014-08-14 20:37:23]

On 2014/08/14 at 00:56:22, enne wrote:
> abarth: Mind taking one more quick look at this change below? I'm not super
familiar with these tests.

+dpranke,ojan as alternate reviewers to take a quick look that this test change
is legit.  I'm not sure how this worked beforehand, so am suspicious that my
change is ok.

[abarth-chromium, 2014-08-14 20:55:01]

https://codereview.chromium.org/473473003/diff/10001/Tools/Scripts/webkitpy/c...
File Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py
(right):

https://codereview.chromium.org/473473003/diff/10001/Tools/Scripts/webkitpy/c...
Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:131:
self.assertEqual(sorted(baseline_optimizer._files_to_delete),
sorted(expected_files_to_delete))
On 2014/08/14 00:56:22, enne wrote:
> Other than search and replacing softwarecompositing => gpu/fast/canvas and
> compositing => fast/canvas, this was the only other change I had to make to
get
> these tests passing.
> 
> I think this is legit.  files_to_delete sounds like an unordered list, so
should
> be sorted first before being compared.

LGTM

[enne (OOO), 2014-08-14 20:55:53]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2014-08-14 20:57:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/enne@chromium.org/473473003/10001

[commit-bot: I haz the power, 2014-08-14 22:06:51]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_db...)
  android_blink_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_re...)
  android_chromium_gn_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_comp...)
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/2...)
  linux_chromium_gn_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/19878)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22826)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[enne (OOO), 2014-08-14 22:14:18]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2014-08-14 22:15:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/enne@chromium.org/473473003/20001

[Dirk Pranke, 2014-08-14 23:17:58]

On 2014/08/14 20:37:23, enne wrote:
> On 2014/08/14 at 00:56:22, enne wrote:
> > abarth: Mind taking one more quick look at this change below? I'm not super
> familiar with these tests.
> 
> +dpranke,ojan as alternate reviewers to take a quick look that this test
change
> is legit.  I'm not sure how this worked beforehand, so am suspicious that my
> change is ok.

That change looks correct.

[commit-bot: I haz the power, 2014-08-15 01:22:33]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[commit-bot: I haz the power, 2014-08-15 01:43:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-15 01:43:30]

Try jobs failed on following builders:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)

[enne (OOO), 2014-08-15 18:48:17]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2014-08-15 18:49:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/enne@chromium.org/473473003/20001

[commit-bot: I haz the power, 2014-08-15 19:07:13]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)

[commit-bot: I haz the power, 2014-08-15 19:26:00]

Committed patchset #3 (20001) as 180387