Fix test for "last updated" text.

Fix test for "last updated" text.

The minutes field was updated to be zero-padded, but the test wasn't, so the
test would fail at certain times of day. This updates that test to always pass.

NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180231

[ojan, 2014-08-14 01:26:48]

https://codereview.chromium.org/473433002/diff/1/Tools/GardeningServer/ui/ct-...
File Tools/GardeningServer/ui/ct-failure-analyzer.html (right):

https://codereview.chromium.org/473433002/diff/1/Tools/GardeningServer/ui/ct-...
Tools/GardeningServer/ui/ct-failure-analyzer.html:70: // FIXME: Change this to
http://sheriff-o-matic.appspot.com/alerts
This was already fixed.

https://codereview.chromium.org/473433002/diff/1/Tools/GardeningServer/ui/tes...
File Tools/GardeningServer/ui/test/ct-last-updated-tests.html (right):

https://codereview.chromium.org/473433002/diff/1/Tools/GardeningServer/ui/tes...
Tools/GardeningServer/ui/test/ct-last-updated-tests.html:27:
lastUpdated.date.getMinutes().toString().padLeft(2, '0');
Can you modify this test to give repeatable results? That means your check can't
actually verify the number of minutes in the X min ago, but the rest can be
something repeatable. That way you can write a test for the unpadded and padded
cases and you can actually test that getHours/getMinutes/padLeft do what you
expect them to.

You can then add a separate test that just tests the minutesAgo behavior the way
this existing test already does.

[teravest, 2014-08-14 03:57:47]

On Wed, Aug 13, 2014 at 7:26 PM,  <ojan@chromium.org> wrote:
>
>
https://codereview.chromium.org/473433002/diff/1/Tools/GardeningServer/ui/ct-...
> File Tools/GardeningServer/ui/ct-failure-analyzer.html (right):
>
>
https://codereview.chromium.org/473433002/diff/1/Tools/GardeningServer/ui/ct-...
> Tools/GardeningServer/ui/ct-failure-analyzer.html:70: // FIXME: Change
> this to http://sheriff-o-matic.appspot.com/alerts
> This was already fixed.

Removed from this change.

>
>
https://codereview.chromium.org/473433002/diff/1/Tools/GardeningServer/ui/tes...
> File Tools/GardeningServer/ui/test/ct-last-updated-tests.html (right):
>
>
https://codereview.chromium.org/473433002/diff/1/Tools/GardeningServer/ui/tes...
> Tools/GardeningServer/ui/test/ct-last-updated-tests.html:27:
> lastUpdated.date.getMinutes().toString().padLeft(2, '0');
> Can you modify this test to give repeatable results? That means your
> check can't actually verify the number of minutes in the X min ago, but
> the rest can be something repeatable. That way you can write a test for
> the unpadded and padded cases and you can actually test that
> getHours/getMinutes/padLeft do what you expect them to.
>
> You can then add a separate test that just tests the minutesAgo behavior
> the way this existing test already does.

I already had a test that checked for the formatting when padding was
necessary, so I added another one that checked the formatting when
padding isn't necessary. That should cover the padding behavior, so
I've left this test as is.

>
> https://codereview.chromium.org/473433002/

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[ojan, 2014-08-14 04:02:19]

lgtm

> >
https://codereview.chromium.org/473433002/diff/1/Tools/GardeningServer/ui/tes...
> > File Tools/GardeningServer/ui/test/ct-last-updated-tests.html (right):
> >
> >
https://codereview.chromium.org/473433002/diff/1/Tools/GardeningServer/ui/tes...
> > Tools/GardeningServer/ui/test/ct-last-updated-tests.html:27:
> > lastUpdated.date.getMinutes().toString().padLeft(2, '0');
> > Can you modify this test to give repeatable results? That means your
> > check can't actually verify the number of minutes in the X min ago, but
> > the rest can be something repeatable. That way you can write a test for
> > the unpadded and padded cases and you can actually test that
> > getHours/getMinutes/padLeft do what you expect them to.
> >
> > You can then add a separate test that just tests the minutesAgo behavior
> > the way this existing test already does.
> 
> I already had a test that checked for the formatting when padding was
> necessary, so I added another one that checked the formatting when
> padding isn't necessary. That should cover the padding behavior, so
> I've left this test as is.

Ah, right. I forgot about that.

[ojan, 2014-08-14 04:02:36]

The CQ bit was checked by ojan@chromium.org

[commit-bot: I haz the power, 2014-08-14 04:03:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/teravest@chromium.org/473433002/20001

[commit-bot: I haz the power, 2014-08-14 04:04:13]

Committed patchset #2 (20001) as 180231