Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Issue 47343002: Pass app URL to mojo_shell on Android (Closed)

Created:
7 years, 1 month ago by abarth-chromium
Modified:
7 years, 1 month ago
CC:
chromium-reviews, craigdh+watch_chromium.org, viettrungluu+watch_chromium.org, Aaron Boodman, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, ben+mojo_chromium.org, darin (slow to review), frankf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Pass app URL to mojo_shell on Android This CL lets us supply an app URL to mojo_shell on Android. To load an app, you can use the adb_run_mojo_shell script: $ ./build/android/adb_run_mojo_shell http://127.0.0.1:4444/libsample_app.so This script starts the MojoShellActivity on the device and passes the URL to mojo_shell via an Android Intent. We're currently using the VIEW intent, but we might want to switch to a different intent at some point. R=darin@chromium.org,aa@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231260

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -12 lines) Patch
build/android/adb_gdb_mojo_shell View 1 chunk +3 lines, -3 lines 0 comments Download
build/android/adb_run_mojo_shell View 1 chunk +1 line, -1 line 0 comments Download
mojo/mojo.gyp View 1 chunk +1 line, -1 line 0 comments Download
mojo/shell/android/mojo_main.cc View 3 chunks +10 lines, -1 line 0 comments Download
mojo/shell/android/shell_apk/src/org/chromium/mojo_shell_apk/MojoMain.java View 1 chunk +3 lines, -3 lines 0 comments Download
mojo/shell/android/shell_apk/src/org/chromium/mojo_shell_apk/MojoShellActivity.java View 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
abarth-chromium
7 years, 1 month ago (2013-10-27 01:31:43 UTC) #1
abarth-chromium
7 years, 1 month ago (2013-10-27 01:31:44 UTC) #2
abarth-chromium
7 years, 1 month ago (2013-10-27 01:31:45 UTC) #3
abarth-chromium
7 years, 1 month ago (2013-10-27 01:31:46 UTC) #4
darin (slow to review)
Can you please re-upload the CL. It looks like Rietveld is missing the chunks :-(
7 years, 1 month ago (2013-10-27 04:23:06 UTC) #5
darin (slow to review)
I just reviewed the unified diff instead. LGTM. Nice catch on the component -> shared_library ...
7 years, 1 month ago (2013-10-27 04:27:18 UTC) #6
abarth-chromium
On 2013/10/27 04:27:18, darin wrote: > Nice catch on the component -> shared_library bit. Thanks!
7 years, 1 month ago (2013-10-27 04:54:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/47343002/1
7 years, 1 month ago (2013-10-27 04:54:24 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-10-27 09:48:49 UTC) #9
Message was sent while issue was closed.
Change committed as 231260

Powered by Google App Engine
This is Rietveld 408576698