Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: extensions/browser/api_test_utils.h

Issue 473363003: Adding support for args as ListValues in extension_function_test_utils. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_function_test_utils.cc ('k') | extensions/browser/api_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api_test_utils.h
diff --git a/extensions/browser/api_test_utils.h b/extensions/browser/api_test_utils.h
index 19af3525bbcc70e808954138bacd54f06794ee80..312815331c3033be19fa4edb18dc4ed46e5dbb92 100644
--- a/extensions/browser/api_test_utils.h
+++ b/extensions/browser/api_test_utils.h
@@ -12,6 +12,7 @@
class UIThreadExtensionFunction;
namespace base {
+class ListValue;
class Value;
}
@@ -24,6 +25,9 @@ class ExtensionFunctionDispatcher;
// TODO(yoz): crbug.com/394840: Remove duplicate functionality in
// chrome/browser/extensions/extension_function_test_utils.h.
+//
+// TODO(ckehoe): Accept args as scoped_ptr<base::Value>,
+// and migrate existing users to the new API.
namespace api_test_utils {
enum RunFunctionFlags { NONE = 0, INCLUDE_INCOGNITO = 1 << 0 };
@@ -70,6 +74,11 @@ bool RunFunction(UIThreadExtensionFunction* function,
content::BrowserContext* context,
scoped_ptr<ExtensionFunctionDispatcher> dispatcher,
RunFunctionFlags flags);
+bool RunFunction(UIThreadExtensionFunction* function,
+ scoped_ptr<base::ListValue> args,
+ content::BrowserContext* context,
+ scoped_ptr<ExtensionFunctionDispatcher> dispatcher,
+ RunFunctionFlags flags);
} // namespace function_test_utils
} // namespace extensions
« no previous file with comments | « chrome/browser/extensions/extension_function_test_utils.cc ('k') | extensions/browser/api_test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698