Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 473363003: Adding support for args as ListValues in extension_function_test_utils. (Closed)

Created:
6 years, 4 months ago by Charlie
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding support for args as ListValues in extension_function_test_utils. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290130

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -4 lines) Patch
M chrome/browser/extensions/extension_function_test_utils.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_function_test_utils.cc View 2 chunks +11 lines, -1 line 0 comments Download
M extensions/browser/api_test_utils.h View 3 chunks +9 lines, -0 lines 0 comments Download
M extensions/browser/api_test_utils.cc View 1 chunk +12 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Charlie
6 years, 4 months ago (2014-08-16 00:05:07 UTC) #1
Charlie
My other CL depends on this one.
6 years, 4 months ago (2014-08-16 00:05:31 UTC) #2
not at google - send to devlin
lgtm
6 years, 4 months ago (2014-08-16 00:08:00 UTC) #3
Charlie
The CQ bit was checked by ckehoe@chromium.org
6 years, 4 months ago (2014-08-16 00:22:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ckehoe@chromium.org/473363003/1
6 years, 4 months ago (2014-08-16 00:24:35 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-16 08:16:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 290130

Powered by Google App Engine
This is Rietveld 408576698