Issue 473283002: Check all scratch texture allocations for image filters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 473283002: Check all scratch texture allocations for image filters. (Closed)

Created:
6 years, 4 months ago by Stephen White

Modified:
6 years, 4 months ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -0 lines)			Patch
M	src/core/SkImageFilter.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/effects/SkDisplacementMapEffect.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/effects/SkMorphologyImageFilter.cpp	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/effects/SkXfermodeImageFilter.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

bsalomon

lgtm. If you want it to land before the M38 branch add NOTREECHECKS=true.

6 years, 4 months ago (2014-08-15 17:39:11 UTC) #2

Stephen White

On 2014/08/15 17:39:11, bsalomon wrote: > lgtm. If you want it to land before the ...

6 years, 4 months ago (2014-08-15 17:40:25 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/senorblanco@chromium.org/473283002/1

6 years, 4 months ago (2014-08-15 17:40:54 UTC) #5

commit-bot: I haz the power

6 years, 4 months ago (2014-08-15 17:48:57 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (1) as 673d9732bf37df724500e04afcdf27d5c711ef60