Towards removing dependency from generic lowering on compilation info.

test/cctest/compiler/function-tester.h

Index: test/cctest/compiler/function-tester.h
diff --git a/test/cctest/compiler/function-tester.h b/test/cctest/compiler/function-tester.h
index 4a416a42082d0f4a54fc4f99ae9aac8af7e1679b..5c79d47a0f216759aef180b9a501cc05a7495f01 100644
--- a/test/cctest/compiler/function-tester.h
+++ b/test/cctest/compiler/function-tester.h
@@ -26,12 +26,12 @@ namespace compiler {
 
 class FunctionTester : public InitializedHandleScope {
  public:
-  explicit FunctionTester(const char* source, bool context_specialization =
-                                                  FLAG_context_specialization)
+  explicit FunctionTester(const char* source, uint32_t flags = 0)
       : isolate(main_isolate()),
         function((FLAG_allow_natives_syntax = true, NewFunction(source))),
-        context_specialization_(context_specialization) {
+        flags_(flags) {
     Compile(function);
+    USE(flags_);

[Michael Starzinger, 2014/08/27 13:26:18]

Why do we need this USE here?

[sigurds, 2014/08/27 13:48:49]

The only use is guarded by V8_TURBOFAN_TARGET, so without this use, some arches
won't compile.

[Michael Starzinger, 2014/08/27 14:06:40]

Acknowledged. Interesting, I didn't know that C-compilers also warn about unused
fields, good to know.

   }
 
   Isolate* isolate;
@@ -45,7 +45,10 @@ class FunctionTester : public InitializedHandleScope {
     StrictMode strict_mode = info.function()->strict_mode();
     info.SetStrictMode(strict_mode);
     info.SetOptimizing(BailoutId::None(), Handle<Code>(function->code()));
-    if (context_specialization_) info.MarkAsContextSpecializing();
+    if (flags_ & CompilationInfo::kContextSpecializing)
+      info.MarkAsContextSpecializing();

[Michael Starzinger, 2014/08/27 13:26:18]

If the condition goes over a line-break then please add curly braces.

[sigurds, 2014/08/27 13:48:49]

Done.

+    if (flags_ & CompilationInfo::kInliningEnabled)
+      info.MarkAsInliningEnabled();
     CHECK(Rewriter::Rewrite(&info));
     CHECK(Scope::Analyze(&info));
     CHECK_NE(NULL, info.scope());
@@ -193,7 +196,7 @@ class FunctionTester : public InitializedHandleScope {
   Handle<Object> false_value() { return isolate->factory()->false_value(); }
 
  private:
-  bool context_specialization_;
+  uint32_t flags_;
 };
 }
 }