Towards removing dependency from generic lowering on compilation info.

test/cctest/compiler/function-tester.h

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_CCTEST_COMPILER_FUNCTION_TESTER_H_
 #define V8_CCTEST_COMPILER_FUNCTION_TESTER_H_
 
 #include "src/v8.h"
 #include "test/cctest/cctest.h"
 
 #include "src/compiler.h"
 #include "src/compiler/pipeline.h"
 #include "src/execution.h"
 #include "src/full-codegen.h"
 #include "src/handles.h"
 #include "src/objects-inl.h"
 #include "src/parser.h"
 #include "src/rewriter.h"
 #include "src/scopes.h"
 
 #define USE_CRANKSHAFT 0
 
 namespace v8 {
 namespace internal {
 namespace compiler {
 
 class FunctionTester : public InitializedHandleScope {
  public:
-  explicit FunctionTester(const char* source, bool context_specialization =
-                                                  FLAG_context_specialization)
+  explicit FunctionTester(const char* source, uint32_t flags = 0)
       : isolate(main_isolate()),
         function((FLAG_allow_natives_syntax = true, NewFunction(source))),
-        context_specialization_(context_specialization) {
+        flags_(flags) {
     Compile(function);
+    USE(flags_);

[Michael Starzinger, 2014/08/27 13:26:18]

Why do we need this USE here?

[sigurds, 2014/08/27 13:48:49]

The only use is guarded by V8_TURBOFAN_TARGET, so without this use, some arches
won't compile.

[Michael Starzinger, 2014/08/27 14:06:40]

Acknowledged. Interesting, I didn't know that C-compilers also warn about unused
fields, good to know.

   }
 
   Isolate* isolate;
   Handle<JSFunction> function;
 
   Handle<JSFunction> Compile(Handle<JSFunction> function) {
 #if V8_TURBOFAN_TARGET
     CompilationInfoWithZone info(function);
 
     CHECK(Parser::Parse(&info));
     StrictMode strict_mode = info.function()->strict_mode();
     info.SetStrictMode(strict_mode);
     info.SetOptimizing(BailoutId::None(), Handle<Code>(function->code()));
-    if (context_specialization_) info.MarkAsContextSpecializing();
+    if (flags_ & CompilationInfo::kContextSpecializing)
+      info.MarkAsContextSpecializing();

[Michael Starzinger, 2014/08/27 13:26:18]

If the condition goes over a line-break then please add curly braces.

[sigurds, 2014/08/27 13:48:49]

Done.

+    if (flags_ & CompilationInfo::kInliningEnabled)
+      info.MarkAsInliningEnabled();
     CHECK(Rewriter::Rewrite(&info));
     CHECK(Scope::Analyze(&info));
     CHECK_NE(NULL, info.scope());
     Handle<ScopeInfo> scope_info = ScopeInfo::Create(info.scope(), info.zone());
     info.shared_info()->set_scope_info(*scope_info);
 
     EnsureDeoptimizationSupport(&info);
 
     Pipeline pipeline(&info);
     Handle<Code> code = pipeline.GenerateCode();
@@ skipping 127 matching lines @@
 
   Handle<Object> undefined() { return isolate->factory()->undefined_value(); }
 
   Handle<Object> null() { return isolate->factory()->null_value(); }
 
   Handle<Object> true_value() { return isolate->factory()->true_value(); }
 
   Handle<Object> false_value() { return isolate->factory()->false_value(); }
 
  private:
-  bool context_specialization_;
+  uint32_t flags_;
 };
 }
 }
 }  // namespace v8::internal::compiler
 
 #endif  // V8_CCTEST_COMPILER_FUNCTION_TESTER_H_