ui: Have shell_dialogs into its own gyp file under its shell_dialogs/ directory.

ui: Have shell_dialogs into its own gyp file under its shell_dialogs/ directory.

This is the pattern we follow for projects under ui/, each top-level directory
(app_list, aura, compositor, events) have its own gyp file for its main target
(library).

BUG=299841
TEST=build/gyp_chromium, ninja -C out/Debug shell_dialogs, and other targets
still build.
R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231478

[tfarina, 2013-10-27 01:06:47]

Hi Ben, please, take a look.

Thanks!

[tfarina, 2013-10-27 03:53:57]

According to Mac, this is creating a cycle:

gyp: Cycles in .gyp file dependency graph detected:
Cycle: ui/shell_dialogs/shell_dialogs.gyp -> ui/ui.gyp ->
ui/shell_dialogs/shell_dialogs.gyp
Cycle: ui/ui.gyp -> ui/shell_dialogs/shell_dialogs.gyp -> ui/ui.gyp

This must be happening because of ui_unittests.gypi, which is included in ui.gyp
and ui_unittests.gypi uses shell_dialogs.gyp.

I'll look into make ui_unittests.gypi a gyp file instead and update this patch.

[tfarina, 2013-10-27 04:29:12]

Mac issue fixed (by making ui_unittests a normal gyp file rather than a gyp
include file)!

[Ben Goodger (Google), 2013-10-28 17:36:32]

lgtm thanks!

[commit-bot: I haz the power, 2013-10-28 18:08:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/47323002/130001

[commit-bot: I haz the power, 2013-10-29 01:32:23]

Change committed as 231478

[lliabraa, 2013-10-30 15:36:27]

On 2013/10/29 01:32:23, I haz the power (commit-bot) wrote:
> Change committed as 231478

I'm pretty sure this broke the iOS bots because the build/all.gyp:All target no
longer builds the ui_unittests target. This is not red on the main waterfall
because the .app generated from previous cycles is still present. However, on
the FYI waterfall (where iOs builders clobber each time) you can see the issue:

http://build.chromium.org/p/chromium.fyi/builders/Chromium%20iOS%20Simulator%...

If you search the stdio from the compile step, you'll see the only reference to
ui_unittests is when it builds ui_test_support, which is pulled in via ui.gyp:*,
but the actual unit tests are not run.

Can you revert this or find a quick fix to get ui_unittests going again?

[lliabraa, 2013-10-30 15:39:33]

https://codereview.chromium.org/47323002/diff/130001/build/all.gyp
File build/all.gyp (right):

https://codereview.chromium.org/47323002/diff/130001/build/all.gyp#newcode74
build/all.gyp:74: 'dependencies': [
maybe add a dependency on ui_unittests here?

https://codereview.chromium.org/47323002/diff/130001/ui/ui.gyp
File ui/ui.gyp (right):

https://codereview.chromium.org/47323002/diff/130001/ui/ui.gyp#newcode338
ui/ui.gyp:338: # iOS only uses a subset of UI.
maybe add the dependency on ui_unittests.gyp here?

[tfarina, 2013-10-30 17:04:45]

lliabraa, I'll only be able to do something in ~4 hours, when I get back home.

[tfarina, 2013-11-01 21:54:49]

https://codereview.chromium.org/47323002/diff/130001/build/all.gyp
File build/all.gyp (right):

https://codereview.chromium.org/47323002/diff/130001/build/all.gyp#newcode28
build/all.gyp:28: '../ui/ui.gyp:*',
ahh, here is the problem :/

this was pulling all the unittest stuff, because ui_unittests.gypi was included
in ui.gyp