Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 473213002: Added support for turning off auto-complete. (Closed)

Created:
6 years, 4 months ago by bcwhite
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Added support for turning off auto-complete. BUG=303883 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289955

Patch Set 1 #

Patch Set 2 : removed unnecessary braces #

Total comments: 2

Patch Set 3 : fixed braces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java View 1 2 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bcwhite
6 years, 4 months ago (2014-08-15 14:37:25 UTC) #1
aurimas (slooooooooow)
lgtm https://codereview.chromium.org/473213002/diff/20001/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java File content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java (right): https://codereview.chromium.org/473213002/diff/20001/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java#newcode68 content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java:68: if ((inputFlags & imeAdapter.sTextInputFlagAutocompleteOff) != 0) Add {} ...
6 years, 4 months ago (2014-08-15 16:36:56 UTC) #2
bcwhite
https://codereview.chromium.org/473213002/diff/20001/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java File content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java (right): https://codereview.chromium.org/473213002/diff/20001/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java#newcode68 content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java:68: if ((inputFlags & imeAdapter.sTextInputFlagAutocompleteOff) != 0) On 2014/08/15 16:36:56, ...
6 years, 4 months ago (2014-08-15 16:59:34 UTC) #3
bcwhite
The CQ bit was checked by bcwhite@chromium.org
6 years, 4 months ago (2014-08-15 17:00:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bcwhite@chromium.org/473213002/40001
6 years, 4 months ago (2014-08-15 17:01:38 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 18:46:34 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (40001) as 289955

Powered by Google App Engine
This is Rietveld 408576698