DocumentParser should flush itself on finish

DocumentParser should flush itself on finish().

Before this patch, |DocumentParser| user had to explicitly
call |flush()| before calling |finish()| to flush any bytes that
may be remaining inside |m_decoder|.
This patch moves |DocumentParser::flush| call inside |finish()|
overrides, and makes |DocumentParser::flush| protected as this
method no longer needs to be called by user.

BUG=404107
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180569

[kouhei (in TOK), 2014-08-15 13:22:30]

Would you take a look?

[abarth-chromium, 2014-08-15 16:52:57]

https://codereview.chromium.org/473203002/diff/1/Source/core/html/parser/HTML...
File Source/core/html/parser/HTMLDocumentParser.cpp (right):

https://codereview.chromium.org/473203002/diff/1/Source/core/html/parser/HTML...
Source/core/html/parser/HTMLDocumentParser.cpp:875: flush();
flush() can produce end up executing arbitrary script, which can end up
destroying |this|.  That's why DocumentWriter null-checks m_parser after calling
flush...

https://codereview.chromium.org/473203002/diff/1/Source/core/loader/DocumentW...
File Source/core/loader/DocumentWriter.cpp (right):

https://codereview.chromium.org/473203002/diff/1/Source/core/loader/DocumentW...
Source/core/loader/DocumentWriter.cpp:117: return;
Presumably this line isn't required anymore.

[kouhei (in TOK), 2014-08-19 02:01:24]

https://codereview.chromium.org/473203002/diff/1/Source/core/html/parser/HTML...
File Source/core/html/parser/HTMLDocumentParser.cpp (right):

https://codereview.chromium.org/473203002/diff/1/Source/core/html/parser/HTML...
Source/core/html/parser/HTMLDocumentParser.cpp:875: flush();
On 2014/08/15 16:52:57, abarth wrote:
> flush() can produce end up executing arbitrary script, which can end up
> destroying |this|.  That's why DocumentWriter null-checks m_parser after
calling
> flush...

Added a protect and return if stopped.

https://codereview.chromium.org/473203002/diff/1/Source/core/loader/DocumentW...
File Source/core/loader/DocumentWriter.cpp (right):

https://codereview.chromium.org/473203002/diff/1/Source/core/loader/DocumentW...
Source/core/loader/DocumentWriter.cpp:117: return;
On 2014/08/15 16:52:57, abarth wrote:
> Presumably this line isn't required anymore.

Done.

[kouhei (in TOK), 2014-08-19 02:20:38]

eh. XSLT tests are failing. looking.

[kouhei (in TOK), 2014-08-19 04:25:18]

On 2014/08/19 02:20:38, kouhei wrote:
> eh. XSLT tests are failing. looking.
Fixed. PTAL

[eseidel, 2014-08-19 04:28:17]

lgtm

[kouhei (in TOK), 2014-08-19 04:35:57]

Thanks for review!

[kouhei (in TOK), 2014-08-19 04:36:01]

The CQ bit was checked by kouhei@chromium.org

[kouhei (in TOK), 2014-08-19 04:36:05]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-08-19 04:36:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kouhei@chromium.org/473203002/80001

[kouhei (in TOK), 2014-08-19 04:38:59]

The CQ bit was unchecked by kouhei@chromium.org

[kouhei (in TOK), 2014-08-19 04:39:20]

Sorry.
abarth: PTAL.

[abarth-chromium, 2014-08-19 16:15:27]

The CQ bit was checked by abarth@chromium.org

[abarth-chromium, 2014-08-19 16:15:28]

Eric's review is fine.  You don't need to wait for me.  :)

[commit-bot: I haz the power, 2014-08-19 16:16:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kouhei@chromium.org/473203002/80001

[commit-bot: I haz the power, 2014-08-19 16:17:58]

Committed patchset #3 (80001) as 180569