Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 473173004: Refactor lazy JNI registration support. (Closed)

Created:
6 years, 4 months ago by Torne
Modified:
6 years, 4 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Project:
chromium
Visibility:
Public.

Description

Refactor lazy JNI registration support. Rename the "linker_script_copy" target to "android_exports" and move the link_settings clause to that target. This avoids the linker flag being duplicated once for every target which includes jni_generator.gypi, which causes problems on some linker versions. BUG=402003 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289941

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -58 lines) Patch
A + build/android/android_exports.gyp View 2 chunks +14 lines, -1 line 0 comments Download
M build/jar_file_jni_generator.gypi View 1 chunk +1 line, -14 lines 0 comments Download
M build/jni_generator.gypi View 2 chunks +1 line, -17 lines 0 comments Download
D build/linker_script_copy.gyp View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Torne
6 years, 4 months ago (2014-08-15 14:13:37 UTC) #1
mkosiba (inactive)
lgtm
6 years, 4 months ago (2014-08-15 14:20:39 UTC) #2
Torne
The CQ bit was checked by torne@chromium.org
6 years, 4 months ago (2014-08-15 14:21:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/473173004/1
6 years, 4 months ago (2014-08-15 14:27:19 UTC) #4
rmcilroy
On 2014/08/15 14:27:19, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 4 months ago (2014-08-15 14:31:30 UTC) #5
rmcilroy
On 2014/08/15 14:27:19, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 4 months ago (2014-08-15 14:31:32 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 18:19:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (1) as 289941

Powered by Google App Engine
This is Rietveld 408576698