google_apis/gaia/fake_gaia.h - Issue 473153002: Inline sign in extracts gaia id from HTTP header and seeds account tracker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gaia/fake_gaia.h

Issue 473153002: Inline sign in extracts gaia id from HTTP header and seeds account tracker (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix one unit test, progress on second Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/signin/core/browser/account_tracker_service.h ('K') | « components/signin/core/browser/account_tracker_service_unittest.cc ('k') | google_apis/gaia/fake_gaia.cc » ('j') | google_apis/gaia/fake_gaia.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: google_apis/gaia/fake_gaia.h

diff --git a/google_apis/gaia/fake_gaia.h b/google_apis/gaia/fake_gaia.h

index 4db3b842e1ae7ad6ad17b947283822bd4cdbd5ff..65fa91193e5da19a133ef52cbfb0f30751db7db4 100644

--- a/google_apis/gaia/fake_gaia.h

+++ b/google_apis/gaia/fake_gaia.h

@@ -74,12 +74,16 @@ class FakeGaia {

// The e-mail address returned by /ListAccounts.

std::string email;

+ // The gaia_id address returned in GAIA headers.

bartfab (slow) 2014/10/17 09:54:56 Nit: s/gaia_id address/GAIA ID/

Roger Tawa OOO till Jul 10th 2014/10/20 16:04:01 Code removed.

+ std::string gaia_id;

};

FakeGaia();

virtual ~FakeGaia();

- void SetFakeMergeSessionParams(const std::string& email,

+ void SetFakeMergeSessionParams(const std::string& gaia_id,

+ const std::string& email,

const std::string& auth_sid_cookie,

const std::string& auth_lsid_cookie);