google_apis/gaia/fake_gaia.cc - Issue 473153002: Inline sign in extracts gaia id from HTTP header and seeds account tracker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gaia/fake_gaia.cc

Issue 473153002: Inline sign in extracts gaia id from HTTP header and seeds account tracker (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebased Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/signin/core/browser/account_tracker_service.cc ('K') | « components/signin/core/browser/account_tracker_service_unittest.cc ('k') | tools/telemetry/telemetry/core/backends/chrome/chromeos_login_ext/main.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: google_apis/gaia/fake_gaia.cc

diff --git a/google_apis/gaia/fake_gaia.cc b/google_apis/gaia/fake_gaia.cc

index 7ba1c585f4d1cde1a527f9b502e20ac121478341..d7217fd48412bf5c26205f150cc6c549f2aecf59 100644

--- a/google_apis/gaia/fake_gaia.cc

+++ b/google_apis/gaia/fake_gaia.cc

@@ -432,7 +432,9 @@ void FakeGaia::HandleServiceLoginAuth(const HttpRequest& request,

http_response->set_code(net::HTTP_TEMPORARY_REDIRECT);

http_response->AddCustomHeader("Location", redirect_url);

http_response->AddCustomHeader("google-accounts-signin",

- base::StringPrintf("email=\"%s\", sessionindex=0", email.c_str()));

+ base::StringPrintf(

+ "email=\"%s\", obfuscatedid=\"12345\", sessionindex=0",

bartfab (slow) 2014/10/14 17:12:38 Nit: Move "12345" to a constant like kTestObfuscat

Roger Tawa OOO till Jul 10th 2014/10/16 02:39:32 Done.

+ email.c_str()));

}

void FakeGaia::HandleSSO(const HttpRequest& request,