Inline sign in extracts gaia id from HTTP header and seeds account tracker

components/signin/core/browser/account_tracker_service.h

Index: components/signin/core/browser/account_tracker_service.h
diff --git a/components/signin/core/browser/account_tracker_service.h b/components/signin/core/browser/account_tracker_service.h
index d973d1cf91cbcf1d81099696068a5331b69450fc..a65626138a8a3170483cacc1473ff782e2df9833 100644
--- a/components/signin/core/browser/account_tracker_service.h
+++ b/components/signin/core/browser/account_tracker_service.h
@@ -79,6 +79,17 @@ class AccountTrackerService : public KeyedService,
   // there are still unfininshed fetchers.
   virtual bool IsAllUserInfoFetched() const;
 
+  // Picks the corect account_id for the specified account depending on the

[bartfab (slow), 2014/10/14 17:12:38]

Nit: s/corect/correct/

[Roger Tawa OOO till Jul 10th, 2014/10/16 02:39:32]

Done.

+  // migration state.
+  std::string PickAccountIdForAccount(const std::string& gaia,
+                                      const std::string& email);
+  static std::string PickAccountIdForAccount(PrefService* pref_service,
+                                             const std::string& gaia,
+                                             const std::string& email);
+
+  // Seed the gaia id and email for the given account_id.

[bartfab (slow), 2014/10/14 17:12:38]

Nit: No |account_id| is being given here, so it is unclear what the comment
refers to.

[guohui, 2014/10/14 18:50:02]

nits:s/Seed/Seeds/

maybe better to rename gaia to gaia_id.

[Roger Tawa OOO till Jul 10th, 2014/10/16 02:39:32]

Fixed up the comment.  Let me know if this is cleared.

[bartfab (slow), 2014/10/17 09:54:55]

The comment is clearer now, thanks. The logic is still a bit convoluted as you
generate a key from |gaia| and |email| under which you then store... |gaia| and
|email|. It is not trivial to figure out what this is about.

+  void SeedAccountInfo(const std::string& gaia, const std::string& email);
+
   AccountIdMigrationState GetMigrationState();
   static AccountIdMigrationState GetMigrationState(PrefService* pref_service);