[Most Visited] Check for Sync state when using SuggestionsService.

components/suggestions/suggestions_utils.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/suggestions/suggestions_utils.h"
+
+namespace suggestions {
+
+SyncState GetSyncState(bool sync_initialized,
+                       bool sync_enabled,

[manzagop (departed), 2014/08/20 15:43:51]

Perhaps put this argument first, since it's the first thing you check. Reading
in this order, you're led to believe you might need to initialize before you can
tell if it's enabled.

[Mathieu, 2014/08/20 18:41:29]

Done.

+                       bool history_sync_enabled) {
+  if (!sync_enabled)
+    return DISABLED;
+  // Sync is enabled.

[manzagop (departed), 2014/08/20 15:43:51]

Not sure about the location of this comment. Same below.

[Mathieu, 2014/08/20 18:41:29]

Done.

+
+  if (!sync_initialized)
+    return NOT_INITIALIZED_ENABLED;
+  // Sync is initialized, enabled.
+
+  return history_sync_enabled ? INITIALIZED_ENABLED_HISTORY : DISABLED;
+}
+
+}  // namespace suggestions