Introduce the basic animation from minimized to bottom.

Introduce the basic animation from minimized to bottom.

BUG=398062
R=sadrul@chromium.org
TBR=volick@chromium.org
TEST=manually

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289986

[sadrul, 2014-08-15 15:36:22]

https://codereview.chromium.org/473113002/diff/20001/athena/home/home_card_im...
File athena/home/home_card_impl.cc (right):

https://codereview.chromium.org/473113002/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.cc:345:
settings.SetTransitionDuration(base::TimeDelta::FromSeconds(5));
That's ... pretty long! Was for debugging, perhaps?

https://codereview.chromium.org/473113002/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.cc:348: (to_state == HomeCard::VISIBLE_MINIMIZED) ?
1.0f : 0.0f);
Do you need to set the opacity to 0/1 beforehand to make sure it does animate?

https://codereview.chromium.org/473113002/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.cc:389: class AnimationObserver : public
ui::ImplicitAnimationObserver {
You should use ui::ClosureAnimationObserver!

[Jun Mukai, 2014-08-15 16:35:08]

https://codereview.chromium.org/473113002/diff/20001/athena/home/home_card_im...
File athena/home/home_card_impl.cc (right):

https://codereview.chromium.org/473113002/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.cc:345:
settings.SetTransitionDuration(base::TimeDelta::FromSeconds(5));
On 2014/08/15 15:36:21, sadrul wrote:
> That's ... pretty long! Was for debugging, perhaps?

Ugh, removed. That is for debugging. Thanks for catching.

https://codereview.chromium.org/473113002/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.cc:348: (to_state == HomeCard::VISIBLE_MINIMIZED) ?
1.0f : 0.0f);
On 2014/08/15 15:36:21, sadrul wrote:
> Do you need to set the opacity to 0/1 beforehand to make sure it does animate?

Not sure what you mean, but if you meant the pattern of: SetOpacity(0); {
ScopedLayerAnimationSettings; ...; SetOpacity(1); }, I don't think we should.

In case of touch swipe, minimized view is in intermediate opacity (see line 309
above), and the animation should start from the current opacity.

https://codereview.chromium.org/473113002/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.cc:389: class AnimationObserver : public
ui::ImplicitAnimationObserver {
On 2014/08/15 15:36:22, sadrul wrote:
> You should use ui::ClosureAnimationObserver!

Done!

[sadrul, 2014-08-15 16:37:26]

lgtm

https://codereview.chromium.org/473113002/diff/20001/athena/home/home_card_im...
File athena/home/home_card_impl.cc (right):

https://codereview.chromium.org/473113002/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.cc:348: (to_state == HomeCard::VISIBLE_MINIMIZED) ?
1.0f : 0.0f);
On 2014/08/15 16:35:08, Jun Mukai wrote:
> On 2014/08/15 15:36:21, sadrul wrote:
> > Do you need to set the opacity to 0/1 beforehand to make sure it does
animate?
> 
> Not sure what you mean, but if you meant the pattern of: SetOpacity(0); {
> ScopedLayerAnimationSettings; ...; SetOpacity(1); }, I don't think we should.
> 
> In case of touch swipe, minimized view is in intermediate opacity (see line
309
> above), and the animation should start from the current opacity.

Sounds good.

[Jun Mukai, 2014-08-15 16:43:39]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-08-15 16:45:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/473113002/40001

[commit-bot: I haz the power, 2014-08-15 18:39:16]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-08-15 18:44:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-15 18:44:08]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Jun Mukai, 2014-08-15 19:37:42]

TBR=vollick for adding ui/compositor dependency to athena/home/DEPS

[Jun Mukai, 2014-08-15 19:37:47]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-08-15 19:41:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/473113002/40001

[commit-bot: I haz the power, 2014-08-15 19:50:23]

Committed patchset #3 (40001) as 289986