Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1143)

Unified Diff: remoting/webapp/unittests/it2me_service_unittest.js

Issue 473073002: Move hello message from It2MeService to It2MeChannel (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address CR feedback Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/unittests/it2me_service_unittest.js
diff --git a/remoting/webapp/unittests/it2me_service_unittest.js b/remoting/webapp/unittests/it2me_service_unittest.js
index a5924262d1a282a653241047627953a7044d6d84..7981152ce71e525448812f2116bafbbdd4d41624 100644
--- a/remoting/webapp/unittests/it2me_service_unittest.js
+++ b/remoting/webapp/unittests/it2me_service_unittest.js
@@ -97,23 +97,23 @@ test('should handle multiple helper connections', function() {
var webappPort2 = createPort('it2me.helper.webapp', 'tabId2');
it2meService.onWebappConnect_(webappPort2);
+ // verify that Hangouts can receive messages from webapp 1
Jamie 2014/08/15 21:57:32 I remember asking for this change in another CL. H
kelvinp 2014/08/15 23:25:01 No, I am just trying address your feedback since I
webappPort.onMessage.mock$fire({
method: 'sessionStateChanged',
state: remoting.ClientSession.State.CONNECTED
});
- // verify that hangout can receive message events from webapp 1
sinon.assert.calledWith(hangoutPort.postMessage, {
method: 'sessionStateChanged',
state: remoting.ClientSession.State.CONNECTED
});
+ // verify that Hangouts can receive messages from webapp 2.
webappPort2.onMessage.mock$fire({
method: 'sessionStateChanged',
state: remoting.ClientSession.State.CLOSED
});
- // verify that hangout can receive message events from webapp 2.
sinon.assert.calledWith(hangoutPort2.postMessage, {
method: 'sessionStateChanged',
state: remoting.ClientSession.State.CLOSED
@@ -129,17 +129,4 @@ test('should reject unknown connection', function() {
sinon.assert.called(randomPort.disconnect);
});
-test('messageExternal("hello") should return supportedFeatures', function() {
- var response = null;
- function callback(msg) {
- response = msg;
- }
-
- it2meService.onMessageExternal_({
- method: 'hello'
- }, null, callback);
-
- QUnit.ok(response.supportedFeatures instanceof Array);
-});
-
})();

Powered by Google App Engine
This is Rietveld 408576698