Move hello message from It2MeService to It2MeChannel

remoting/webapp/unittests/it2me_helper_channel_unittest.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 (function() {
 
 'use strict';
 
 var appLauncher = null;
 var hangoutPort = null;
@@ skipping 43 matching lines @@
 });
 
 function promiseResolveSynchronous(value) {
   return {
     then: function(callback) {
       callback('tabId');
     }
   };
 }
 
+test('onHangoutMessage_("hello") should return supportedFeatures', function() {
+  hangoutPort.onMessage.mock$fire(
+      { method: remoting.It2MeHelperChannel.HangoutMessageTypes.HELLO });
+
+  var spyCall = hangoutPort.postMessage.firstCall;
+  var message = spyCall.args[0];
+
+  QUnit.equal(message.method, 'helloResponse');

[Jamie, 2014/08/15 21:57:31]

remoting.It2MeHelperChannel.HangoutMessageTypes.HELLO_RESPONSE

[kelvinp, 2014/08/15 23:25:01]

Done.

+  QUnit.ok(message.supportedFeatures instanceof Array);

[Jamie, 2014/08/15 21:57:31]

I think it might be worth checking that it's equal to some permutation of
remoting.It2MeHelperChannel.Features.

[kelvinp, 2014/08/15 23:25:01]

Done.

+});
+
 test('onHangoutMessage_(|connect|) should launch the webapp',
     function() {
   sinon.assert.called(appLauncher.launch);
   QUnit.equal(helperChannel.instanceId(), 'tabId');
 });
 
 test('onWebappMessage() should forward messages to hangout', function() {
   // Execute.
   helperChannel.onWebappConnect(webappPort);
   webappPort.onMessage.mock$fire({
@@ skipping 39 matching lines @@
     state:remoting.ClientSession.State.CLOSED
   });
 
   webappPort.onDisconnect.mock$fire();
 
   // Verify events are forwarded.
   sinon.assert.calledWith(hangoutPort.postMessage, {
     method:'sessionStateChanged',
     state:remoting.ClientSession.State.CLOSED
   });
+
+  sinon.assert.neverCalledWith(hangoutPort.postMessage, {
+    method:'sessionStateChanged',
+    state:remoting.ClientSession.State.FAILED
+  });

[Jamie, 2014/08/15 21:57:32]

Is this related to this CL?

[kelvinp, 2014/08/15 23:25:01]

Done.

+
   sinon.assert.called(hangoutPort.disconnect);
   sinon.assert.calledOnce(disconnectCallback);
 });
 
 test('should notify hangout when the session has error', function() {
   helperChannel.onWebappConnect(webappPort);
   webappPort.onMessage.mock$fire({
     method:'sessionStateChanged',
     state:remoting.ClientSession.State.FAILED
   });
@@ skipping 37 matching lines @@
   hangoutPort.onDisconnect.mock$fire();
 
   sinon.assert.calledOnce(appLauncher.close);
   sinon.assert.calledOnce(disconnectCallback);
 
   sinon.assert.called(hangoutPort.disconnect);
   sinon.assert.called(webappPort.disconnect);
 });
 
 })();