Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 473053002: Properly resume scrolling if a fling ends during a suppressed scroll (Closed)

Created:
6 years, 4 months ago by jdduke (slow)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jdduke+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Properly resume scrolling if a fling ends during a suppressed scroll As a boosted fling may suppress a new scroll sequence in anticipation of a follow-up fling event, it's important that scrolling properly resume if the boosted fling terminates during said suppressed scroll. Normally, a synthetic GestureScrollBegin is used to kickstart the scroll in such cases. However, if the fling naturally terminates by either overscrolling or ticking beyond its lifetime, we failed to resume touch scrolling. This led to unexpected cases where a GestureScrollUpdate would be processed without an antecedent GestureScrollBegin. Address this by always inserting the appropriate synthetic GestureScrollBegin if the fling terminates for any reason. BUG=402077 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290027

Patch Set 1 #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -44 lines) Patch
M content/renderer/input/input_handler_proxy.h View 1 2 chunks +9 lines, -6 lines 0 comments Download
M content/renderer/input/input_handler_proxy.cc View 1 11 chunks +42 lines, -38 lines 0 comments Download
M content/renderer/input/input_handler_proxy_unittest.cc View 1 chunk +70 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jdduke (slow)
aelias@: PTAL, thanks (if you're swamped with code reviews I'll find somebody else =/).
6 years, 4 months ago (2014-08-15 16:46:33 UTC) #1
aelias_OOO_until_Jul13
lgtm
6 years, 4 months ago (2014-08-15 18:21:59 UTC) #2
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 4 months ago (2014-08-15 18:26:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/473053002/60001
6 years, 4 months ago (2014-08-15 18:32:29 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 22:05:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (60001) as 290027

Powered by Google App Engine
This is Rietveld 408576698