Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 47303007: Revert 232517 "Component updater on-demand logic with Resource T..." (Closed)

Created:
7 years, 1 month ago by scherkus (not reviewing)
Modified:
7 years, 1 month ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 232517 "Component updater on-demand logic with Resource T..." It's causing tests to die with the following: [4915:73475:1101/175609:1317657134071:FATAL:browser_process_impl.cc(432)] Check failed: CalledOnValidThread(). > Component updater on-demand logic with Resource Throttle > > This CL introduces the new way to ask for an on demand install when you have a network request that needs the component to be present: > > ComponentUpdaterService::GetOnDemandResourceThrottle() > > Returns a resource throttle and initiates a update check + install immediately. The network request associated with the request is unblocked once the component is installed. > > The unittests are in progress here > https://codereview.chromium.org/55303002/ > > BUG=307193 > TEST=none > R=darin@chromium.org, sorin@chromium.org, waffles@chromium.org > > Review URL: https://codereview.chromium.org/25713007 TBR=cpu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232537

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -176 lines) Patch
M trunk/src/chrome/browser/component_updater/component_updater_service.h View 2 chunks +0 lines, -11 lines 0 comments Download
M trunk/src/chrome/browser/component_updater/component_updater_service.cc View 10 chunks +3 lines, -129 lines 0 comments Download
M trunk/src/chrome/browser/component_updater/crx_update_item.h View 2 chunks +0 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 3 chunks +0 lines, -31 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scherkus (not reviewing)
7 years, 1 month ago (2013-11-02 01:08:10 UTC) #1
scherkus (not reviewing)
Committed patchset #1 manually as r232537.
7 years, 1 month ago (2013-11-02 01:08:19 UTC) #2
scherkus (not reviewing)
7 years, 1 month ago (2013-11-02 01:09:24 UTC) #3
Message was sent while issue was closed.
On 2013/11/02 01:08:19, scherkus wrote:
> Committed patchset #1 manually as r232537.

Here are some logs 'n stack traces:
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.7%20Tes...
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.7%20Tes...
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.7%20Tes...

[4914:73475:1101/175609:1317681066225:FATAL:browser_process_impl.cc(432)] Check
failed: CalledOnValidThread().
0   libbase.dylib                       0x0f2e3aff
base::debug::StackTrace::StackTrace() + 63
1   libbase.dylib                       0x0f2e3a9b
base::debug::StackTrace::StackTrace() + 43
2   libbase.dylib                       0x0f3718dc
logging::LogMessage::~LogMessage() + 76
3   libbase.dylib                       0x0f3703db
logging::LogMessage::~LogMessage() + 43
4   browser_tests                       0x0122d095
BrowserProcessImpl::io_thread() + 261
5   browser_tests                       0x012315f4
BrowserProcessImpl::component_updater() + 84
6   browser_tests                       0x01e5363e (anonymous
namespace)::AppendComponentUpdaterThrottles(net::URLRequest*,
content::ResourceContext*, ResourceType::Type,
ScopedVector<content::ResourceThrottle>*) + 286
7   browser_tests                       0x01e53070
ChromeResourceDispatcherHostDelegate::RequestBeginning(net::URLRequest*,
content::ResourceContext*, appcache::AppCacheService*, ResourceType::Type, int,
int, ScopedVector<content::ResourceThrottle>*) + 624
8   libcontent.dylib                    0x12e41128
content::ResourceDispatcherHostImpl::BeginRequest(int, ResourceHostMsg_Request
const&, IPC::Message*, int) + 4552
9   libcontent.dylib                    0x12e3fcdf
content::ResourceDispatcherHostImpl::OnRequestResource(IPC::Message const&, int,
ResourceHostMsg_Request const&) + 127
10  libcontent.dylib                    0x12e4cabe bool
ResourceHostMsg_RequestResource::Dispatch<content::ResourceDispatcherHostImpl,
content::ResourceDispatcherHostImpl, int, ResourceHostMsg_Request
const&>(IPC::Message const*, content::ResourceDispatcherHostImpl*,
content::ResourceDispatcherHostImpl*, void
(content::ResourceDispatcherHostImpl::*)(IPC::Message const&, int,
ResourceHostMsg_Request const&)) + 254
11  libcontent.dylib                    0x12e3f5e1
content::ResourceDispatcherHostImpl::OnMessageReceived(IPC::Message const&,
content::ResourceMessageFilter*, bool*) + 513
12  libcontent.dylib                    0x12e81866
content::ResourceMessageFilter::OnMessageReceived(IPC::Message const&, bool*) +
86
13  libcontent.dylib                    0x129230ce
content::BrowserMessageFilter::Internal::DispatchMessage(IPC::Message const&) +
110
14  libcontent.dylib                    0x12922a2b
content::BrowserMessageFilter::Internal::OnMessageReceived(IPC::Message const&)
+ 475
15  libipc.dylib                        0x213217d8
IPC::ChannelProxy::Context::TryFilters(IPC::Message const&) + 184
16  libipc.dylib                        0x213218ac
IPC::ChannelProxy::Context::OnMessageReceived(IPC::Message const&) + 60
17  libipc.dylib                        0x2132c3e9
IPC::internal::ChannelReader::DispatchInputData(char const*, int) + 1129
18  libipc.dylib                        0x2132bf2a
IPC::internal::ChannelReader::ProcessIncomingMessages() + 394
19  libipc.dylib                        0x2131283d
IPC::Channel::ChannelImpl::OnFileCanReadWithoutBlocking(int) + 1869
20  libipc.dylib                        0x21312a9f non-virtual thunk to
IPC::Channel::ChannelImpl::OnFileCanReadWithoutBlocking(int) + 63
21  libbase.dylib                       0x0f299a17
base::MessagePumpLibevent::FileDescriptorWatcher::OnFileCanReadWithoutBlocking(int,
base::MessagePumpLibevent*) + 103
22  libbase.dylib                       0x0f29b3cb
base::MessagePumpLibevent::OnLibeventNotification(int, short, void*) + 459
23  libbase.dylib                       0x0f4b8e5a event_process_active + 410
24  libbase.dylib                       0x0f4b80d2 event_base_loop + 498
25  libbase.dylib                       0x0f29b9bf
base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) + 1279
26  libbase.dylib                       0x0f39d673
base::MessageLoop::RunInternal() + 291
27  libbase.dylib                       0x0f39d52b
base::MessageLoop::RunHandler() + 43
28  libbase.dylib                       0x0f40c808 base::RunLoop::Run() + 72
29  libbase.dylib                       0x0f39c927 base::MessageLoop::Run() + 55
30  libbase.dylib                       0x0f479eb2
base::Thread::Run(base::MessageLoop*) + 50
31  libcontent.dylib                    0x129df137
content::BrowserThreadImpl::IOThreadRun(base::MessageLoop*) + 71
32  libcontent.dylib                    0x129df346
content::BrowserThreadImpl::Run(base::MessageLoop*) + 326
33  libbase.dylib                       0x0f47a09f base::Thread::ThreadMain() +
335
34  libbase.dylib                       0x0f4600bb base::(anonymous
namespace)::ThreadFunc(void*) + 299
35  libsystem_c.dylib                   0x90f75ed9 _pthread_start + 335
36  libsystem_c.dylib                   0x90f796de thread_start + 34

Powered by Google App Engine
This is Rietveld 408576698