Implement native bindings for cast extensions API

chrome/renderer/extensions/webrtc_native_handler.cc

Index: chrome/renderer/extensions/webrtc_native_handler.cc
diff --git a/chrome/renderer/extensions/webrtc_native_handler.cc b/chrome/renderer/extensions/webrtc_native_handler.cc
index 8ea32ee30715358cb67f440c1a4770279393190a..8b59c80b5236b012dd96e87d5d534b3e2ab2c555 100644
--- a/chrome/renderer/extensions/webrtc_native_handler.cc
+++ b/chrome/renderer/extensions/webrtc_native_handler.cc
@@ -5,11 +5,64 @@
 #include "chrome/renderer/extensions/webrtc_native_handler.h"
 
 #include "base/logging.h"
+#include "chrome/common/extensions/api/webrtc_cast_send_transport.h"
+#include "chrome/common/extensions/api/webrtc_cast_udp_transport.h"

[not at google - send to devlin, 2013/10/30 20:41:57]

you can't use the generated objects on the renderer unfortunately. this will at
some point mysteriously fail to compile because renderer.gyp doesn't depend on
api.gyp; and we can't make renderer.gyp depend on api.gyp because that would end
up pulling in a lot of code.

if you want to make this work then you could pull out just the parts you need
into a separate rule in api.gyp, like api.gyp:renderer_apis or something. make
sure the binary size of the renderer doesn't grow too much.

or, just hand-write the conversion.

it's a long-standing TODO (bug somewhere) to generate a direct v8 conversion
rather than going via v8::Value, but, that's probably never going to happen,
value hasn't been high enough.

[Alpha Left Google, 2013/10/30 23:58:26]

I observed that chrome_common.gypi depends on api.gyp:api. This means both
renderer and browser link to the API. Is this a future work to isolate the
browser API from renderer?

Anyway I have created a api_renderer target that includes only the two files I
need. They are both very small.
I would like to avoid doing this. It's too tedious for future updates and easy
to get wrong.

+#include "chrome/renderer/extensions/chrome_v8_context.h"
+#include "chrome/renderer/media/cast_send_transport.h"
+#include "chrome/renderer/media/cast_session.h"
+#include "chrome/renderer/media/cast_udp_transport.h"
+#include "content/public/renderer/v8_value_converter.h"
+#include "net/base/host_port_pair.h"
+
+using content::V8ValueConverter;
+
+// Extension types.
+using extensions::api::webrtc_cast_send_transport::RtpCaps;
+using extensions::api::webrtc_cast_send_transport::RtpParams;
+using extensions::api::webrtc_cast_send_transport::RtpPayloadParams;
+using extensions::api::webrtc_cast_udp_transport::CreateInfo;
+using extensions::api::webrtc_cast_udp_transport::UdpParams;
 
 namespace extensions {
 
+namespace {
+const char kSendTransportNotFound[] = "The send transport cannot be found";
+const char kUdpTransportNotFound[] = "The UDP transport cannot be found";
+const char kInvalidUdpParams[] = "Invalid UDP params";
+const char kInvalidRtpCaps[] = "Invalid value for RTP caps";
+const char kInvalidRtpParams[] = "Invalid value for RTP params";
+const char kUnableToConvertArgs[] = "Unable to convert arguments";
+const char kUnableToConvertCaps[] = "Unable to convert caps";
+const char kUnableToConvertParams[] = "Unable to convert params";
+
+// These helper methods are used to convert between Extension API
+// types and Cast types.
+bool ToCastRtpCaps(const RtpCaps& ext_caps, CastRtpCaps* cast_caps) {
+  NOTIMPLEMENTED();
+  return true;
+}
+
+bool FromCastRtpCaps(const CastRtpCaps& cast_caps, RtpCaps* ext_caps) {
+  NOTIMPLEMENTED();
+  return true;
+}
+
+bool ToCastRtpParams(const RtpParams& ext_params, CastRtpParams* cast_params) {
+  NOTIMPLEMENTED();
+  return true;
+}
+
+bool FromCastRtpParams(const CastRtpParams& cast_params,
+                       RtpParams* ext_params) {
+  NOTIMPLEMENTED();
+  return true;
+}
+
+}  // namespace
+
 WebRtcNativeHandler::WebRtcNativeHandler(ChromeV8Context* context)
-    : ObjectBackedNativeHandler(context) {
+    : ObjectBackedNativeHandler(context),
+      last_transport_id_(0) {
   RouteFunction("CreateCastSendTransport",
       base::Bind(&WebRtcNativeHandler::CreateCastSendTransport,
                  base::Unretained(this)));
@@ -31,6 +84,9 @@ WebRtcNativeHandler::WebRtcNativeHandler(ChromeV8Context* context)
   RouteFunction("CreateCastUdpTransport",
       base::Bind(&WebRtcNativeHandler::CreateCastUdpTransport,
                  base::Unretained(this)));
+  RouteFunction("DestroyCastUdpTransport",
+      base::Bind(&WebRtcNativeHandler::DestroyCastUdpTransport,
+                 base::Unretained(this)));
   RouteFunction("StartCastUdpTransport",
       base::Bind(&WebRtcNativeHandler::StartCastUdpTransport,
                  base::Unretained(this)));
@@ -44,47 +100,274 @@ WebRtcNativeHandler::~WebRtcNativeHandler() {
 
 void WebRtcNativeHandler::CreateCastSendTransport(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
-  NOTIMPLEMENTED();
+  CHECK_EQ(3, args.Length());
+  CHECK(args[0]->IsInt32());
+  CHECK(args[1]->IsObject());
+  CHECK(args[2]->IsFunction());
+
+  const int inner_transport_id = static_cast<int>(args[0]->ToInt32()->Value());

[not at google - send to devlin, 2013/10/30 20:41:57]

use args[0]->Cast<v8::Int32> here, more efficient than doing a conversion.
slightly. well, it's 0 effort rather than >0.

same elsewhere.

[not at google - send to devlin, 2013/10/30 20:44:15]

actually you should probably use args[0]->IsInteger and use ToInt32 after all :)

[Alpha Left Google, 2013/10/30 23:58:26]

There's only IsInt32() but not IsInteger(). I dropped the static_cast though.

+  CastUdpTransport* inner_transport = GetUdpTransport(inner_transport_id);
+  if (!inner_transport) {
+    v8::ThrowException(v8::Exception::RangeError(v8::String::New(
+        kUdpTransportNotFound)));
+    return;
+  }
+
+  // TODO(hclam): Convert second argument from v8::Value to
+  // WebMediaStreamTrack.
+  int transport_id = last_transport_id_++;
+  send_transport_map_[transport_id] =
+      linked_ptr<CastSendTransport>(new CastSendTransport(inner_transport));
+
+  v8::Handle<v8::Value> transport_id_v8 = v8::Integer::New(transport_id);
+  context()->CallFunction(v8::Handle<v8::Function>::Cast(args[2]), 1,
+                          &transport_id_v8);
 }
 
 void WebRtcNativeHandler::DestroyCastSendTransport(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
-  NOTIMPLEMENTED();
+  CHECK_EQ(1, args.Length());
+  CHECK(args[0]->IsInt32());
+
+  const int transport_id = static_cast<int>(args[0]->ToInt32()->Value());
+  if (!GetSendTransport(transport_id)) {
+    v8::ThrowException(v8::Exception::RangeError(v8::String::New(
+        kSendTransportNotFound)));
+    return;
+  }
+  send_transport_map_.erase(transport_id);
 }
 
 void WebRtcNativeHandler::CreateParamsCastSendTransport(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
-  NOTIMPLEMENTED();
+  CHECK_EQ(3, args.Length());
+  CHECK(args[0]->IsInt32());
+  CHECK(args[1]->IsObject());
+  CHECK(args[2]->IsFunction());
+
+  const int transport_id = static_cast<int>(args[0]->ToInt32()->Value());
+  CastSendTransport* transport = GetSendTransport(transport_id);
+  if (!transport) {
+    v8::ThrowException(v8::Exception::RangeError(v8::String::New(
+        kSendTransportNotFound)));
+    return;
+  }
+
+  scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create());
+  scoped_ptr<Value> remote_caps_value(
+      converter->FromV8Value(args[1], context()->v8_context()));
+  if (!remote_caps_value) {
+    v8::ThrowException(v8::Exception::TypeError(v8::String::New(
+        kUnableToConvertArgs)));
+    return;
+  }
+  scoped_ptr<RtpCaps> remote_caps =
+      RtpCaps::FromValue(*remote_caps_value);
+  if (!remote_caps) {
+    v8::ThrowException(v8::Exception::TypeError(v8::String::New(
+        kInvalidRtpCaps)));
+    return;
+  }
+
+  CastRtpCaps cast_remote_caps;
+  if (!ToCastRtpCaps(*remote_caps, &cast_remote_caps)) {
+    v8::ThrowException(v8::Exception::TypeError(v8::String::New(
+        kUnableToConvertCaps)));
+    return;
+  }
+  CastRtpParams cast_params = transport->CreateParams(cast_remote_caps);
+  RtpParams params;
+  if (!FromCastRtpParams(cast_params, &params)) {
+    v8::ThrowException(v8::Exception::TypeError(v8::String::New(
+        kUnableToConvertParams)));
+    return;
+  }
+
+  scoped_ptr<base::DictionaryValue> params_value = params.ToValue();
+  v8::Handle<v8::Value> params_v8 = converter->ToV8Value(
+      params_value.get(), context()->v8_context());
+  context()->CallFunction(v8::Handle<v8::Function>::Cast(args[2]), 1,
+                          &params_v8);
 }
 
 void WebRtcNativeHandler::GetCapsCastSendTransport(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
-  NOTIMPLEMENTED();
+  CHECK_EQ(2, args.Length());
+  CHECK(args[0]->IsInt32());
+  CHECK(args[1]->IsFunction());
+
+  const int transport_id = static_cast<int>(args[0]->ToInt32()->Value());
+  CastSendTransport* transport = GetSendTransport(transport_id);
+  if (!transport) {
+    v8::ThrowException(v8::Exception::RangeError(v8::String::New(
+        kSendTransportNotFound)));
+    return;
+  }
+
+  CastRtpCaps cast_caps = transport->GetCaps();
+  RtpCaps caps;
+  if (!FromCastRtpCaps(cast_caps, &caps)) {
+    v8::ThrowException(v8::Exception::TypeError(v8::String::New(
+        kUnableToConvertCaps)));
+    return;
+  }
+
+  scoped_ptr<base::DictionaryValue> caps_value = caps.ToValue();
+  scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create());
+  v8::Handle<v8::Value> caps_v8 = converter->ToV8Value(
+      caps_value.get(), context()->v8_context());
+  context()->CallFunction(v8::Handle<v8::Function>::Cast(args[1]), 1,
+                          &caps_v8);
 }
 
 void WebRtcNativeHandler::StartCastSendTransport(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
-  NOTIMPLEMENTED();
+  CHECK_EQ(2, args.Length());
+  CHECK(args[0]->IsInt32());
+  CHECK(args[1]->IsObject());
+
+  const int transport_id = static_cast<int>(args[0]->ToInt32()->Value());
+  CastSendTransport* transport = GetSendTransport(transport_id);
+  if (!transport) {
+    v8::ThrowException(v8::Exception::RangeError(v8::String::New(
+        kSendTransportNotFound)));
+    return;
+  }
+
+  scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create());
+  scoped_ptr<Value> params_value(
+      converter->FromV8Value(args[1], context()->v8_context()));
+  if (!params_value) {
+    v8::ThrowException(v8::Exception::TypeError(v8::String::New(
+        kUnableToConvertParams)));
+    return;
+  }
+  scoped_ptr<RtpParams> params = RtpParams::FromValue(*params_value);
+  if (!params) {
+    v8::ThrowException(v8::Exception::TypeError(v8::String::New(
+        kInvalidRtpParams)));
+    return;
+  }
+
+  CastRtpCaps cast_params;
+  if (!ToCastRtpParams(*params, &cast_params)) {
+    v8::ThrowException(v8::Exception::TypeError(v8::String::New(
+        kUnableToConvertParams)));
+    return;
+  }
+  transport->Start(cast_params);
 }
 
 void WebRtcNativeHandler::StopCastSendTransport(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
-  NOTIMPLEMENTED();
+  CHECK_EQ(1, args.Length());
+  CHECK(args[0]->IsInt32());
+
+  const int transport_id = static_cast<int>(args[0]->ToInt32()->Value());
+  CastSendTransport* transport = GetSendTransport(transport_id);
+  if (!transport) {
+    v8::ThrowException(v8::Exception::RangeError(v8::String::New(
+        kSendTransportNotFound)));
+    return;
+  }
+  transport->Stop();
 }
 
 void WebRtcNativeHandler::CreateCastUdpTransport(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
-  NOTIMPLEMENTED();
+  CHECK_EQ(1, args.Length());
+  CHECK(args[0]->IsFunction());
+
+  // TODO(hclam): Fill in |create_info| properly.
+  CreateInfo create_info;
+  create_info.transport_id = last_transport_id_++;
+  udp_transport_map_[create_info.transport_id] =
+      linked_ptr<CastUdpTransport>(new CastUdpTransport());
+
+  scoped_ptr<base::DictionaryValue> create_info_value = create_info.ToValue();
+  scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create());
+  v8::Handle<v8::Value> create_info_v8 = converter->ToV8Value(
+      create_info_value.get(), context()->v8_context());
+  context()->CallFunction(v8::Handle<v8::Function>::Cast(
+      args[0]), 1, &create_info_v8);
+}
+
+void WebRtcNativeHandler::DestroyCastUdpTransport(
+    const v8::FunctionCallbackInfo<v8::Value>& args) {
+  CHECK_EQ(1, args.Length());
+  CHECK(args[0]->IsInt32());
+
+  const int transport_id = static_cast<int>(args[0]->ToInt32()->Value());
+  if (!GetUdpTransport(transport_id)) {
+    v8::ThrowException(v8::Exception::RangeError(v8::String::New(
+        kUdpTransportNotFound)));
+    return;
+  }
+  udp_transport_map_.erase(transport_id);
 }
 
 void WebRtcNativeHandler::StartCastUdpTransport(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
-  NOTIMPLEMENTED();
+  CHECK_EQ(2, args.Length());
+  CHECK(args[0]->IsInt32());
+  CHECK(args[1]->IsObject());
+
+  const int transport_id = static_cast<int>(args[0]->ToInt32()->Value());
+  CastUdpTransport* transport = GetUdpTransport(transport_id);
+  if (!transport) {
+    v8::ThrowException(v8::Exception::RangeError(v8::String::New(
+        kUdpTransportNotFound)));
+    return;
+  }
+
+  scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create());
+  scoped_ptr<Value> udp_params_value(
+      converter->FromV8Value(args[1], context()->v8_context()));
+  if (!udp_params_value) {
+    v8::ThrowException(v8::Exception::TypeError(v8::String::New(
+        kUnableToConvertArgs)));
+    return;
+  }
+  scoped_ptr<UdpParams> udp_params = UdpParams::FromValue(*udp_params_value);
+  if (!udp_params) {
+    v8::ThrowException(v8::Exception::TypeError(v8::String::New(
+        kInvalidUdpParams)));
+    return;
+  }
+  transport->Start(net::HostPortPair(udp_params->address, udp_params->port));
 }
 
 void WebRtcNativeHandler::StopCastUdpTransport(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
-  NOTIMPLEMENTED();
+  CHECK_EQ(1, args.Length());
+  CHECK(args[0]->IsInt32());
+
+  const int transport_id = static_cast<int>(args[0]->ToInt32()->Value());
+  CastUdpTransport* transport = GetUdpTransport(transport_id);
+  if (!transport) {
+    v8::ThrowException(v8::Exception::RangeError(v8::String::New(
+        kUdpTransportNotFound)));
+    return;
+  }
+  transport->Stop();
+}
+
+CastSendTransport* WebRtcNativeHandler::GetSendTransport(

[not at google - send to devlin, 2013/10/30 20:41:57]

maybe this method should actually throw the v8::exception, since every caller is
doing that, use something like:

CastSendTransport* cast_send_transport = NULL;
if (!(cast_send_transport = GetSendTransport(id))
  return;

[Alpha Left Google, 2013/10/30 23:58:26]

I think this is a difference in style. scherkus@ prefers to have the caller to
throw the exception. It's probably clearer that way.

[not at google - send to devlin, 2013/10/31 02:44:44]

I understand your point, but I think it would be better to both have less code
and an obviously consistent error reporting mechanism.

Perhaps if you called this method GetSendTransportOrThrow (or similar) it would
be clearer at the call site what was happening?

+    int transport_id) const {
+  SendTransportMap::const_iterator iter = send_transport_map_.find(
+      transport_id);
+  if (iter != send_transport_map_.end())
+    return iter->second.get();
+  return NULL;
+}
+
+CastUdpTransport* WebRtcNativeHandler::GetUdpTransport(

[not at google - send to devlin, 2013/10/30 20:41:57]

ditto

+    int transport_id) const {
+  UdpTransportMap::const_iterator iter = udp_transport_map_.find(
+      transport_id);
+  if (iter != udp_transport_map_.end())
+    return iter->second.get();
+  return NULL;
 }
 
 }  // namespace extensions