chrome/renderer/resources/extensions/webrtc_cast_send_transport_custom_bindings.js - Issue 47303005: Implement native bindings for cast extensions API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/webrtc_cast_send_transport_custom_bindings.js

Issue 47303005: Implement native bindings for cast extensions API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fixed nits Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/extensions/webrtc_native_handler.cc ('K') | « chrome/renderer/media/cast_udp_transport.cc ('k') | chrome/test/data/extensions/api_test/webrtc_cast/basics.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/webrtc_cast_send_transport_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/webrtc_cast_send_transport_custom_bindings.js b/chrome/renderer/resources/extensions/webrtc_cast_send_transport_custom_bindings.js

index f295a0abaeb58729cd2426b09413809f7d13a877..175eadc72a761ef8512b235c3b3afa645c31d783 100644

--- a/chrome/renderer/resources/extensions/webrtc_cast_send_transport_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/webrtc_cast_send_transport_custom_bindings.js

@@ -11,8 +11,8 @@ binding.registerCustomHook(function(bindingsAPI, extensionId) {

var apiFunctions = bindingsAPI.apiFunctions;

apiFunctions.setHandleRequest('create',

scherkus (not reviewing) 2013/10/30 17:56:35 kalman: are you saying that we should be doing arg

not at google - send to devlin 2013/10/30 18:13:48 Actually it looks like validation does happen by d

- function(track, innerTransportId, callback) {

- webrtc.CreateCastSendTransport(track, innerTransportId, callback);

+ function(innerTransportId, track, callback) {

+ webrtc.CreateCastSendTransport(innerTransportId, track, callback);

});

apiFunctions.setHandleRequest('destroy',

function(transportId) {