Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2310)

Unified Diff: chrome/common/extensions/api/webrtc_cast_send_transport.idl

Issue 47303005: Implement native bindings for cast extensions API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/webrtc_cast_send_transport.idl
diff --git a/chrome/common/extensions/api/webrtc_cast_send_transport.idl b/chrome/common/extensions/api/webrtc_cast_send_transport.idl
index 3070bde473446caa8537c1718d472c3304e07e0c..f101d681519465b4d3a59fe5eb536e7bfebc0aa8 100644
--- a/chrome/common/extensions/api/webrtc_cast_send_transport.idl
+++ b/chrome/common/extensions/api/webrtc_cast_send_transport.idl
@@ -7,13 +7,13 @@
// the given RtpParams.
namespace webrtc.castSendTransport {
// Params for audio and video codec.
- dictionary CodecSpecificParam {
+ dictionary CodecSpecificParams {
DOMString key;
DOMString value;
};
// RTP payload param.
- dictionary RtpPayloadParam {
+ dictionary RtpPayloadParams {
long payloadType;
DOMString codecName;
@@ -37,13 +37,13 @@ namespace webrtc.castSendTransport {
long? height;
// A list of codec specific params.
- CodecSpecificParam[] codecSpecficParams;
+ CodecSpecificParams[] codecSpecficParams;
};
// Cast transport capabilities
- dictionary CastTransportCaps {
+ dictionary RtpCaps {
// RTP payload params.
- RtpPayloadParam[] payloads;
+ RtpPayloadParams[] payloads;
DOMString[] rtcpFeatures;
@@ -51,42 +51,36 @@ namespace webrtc.castSendTransport {
};
// Cast transport params.
- dictionary CastTransportParams {
+ dictionary RtpParams {
// RTP payload params.
- RtpPayloadParam[] payloads;
+ RtpPayloadParams[] payloads;
DOMString[] rtcpFeatures;
DOMString[] fecMechanisms;
};
- // Result of <code>create</code> call.
- dictionary CreateInfo {
- // The ID of the newly created transport.
- long transportId;
- };
-
// Callback from the <code>create</code> method.
// |id| : The transport id.
- callback CreateCallback = void (CreateInfo info);
+ callback CreateCallback = void (long transportId);
// Callback from the <code>createParams</code> method.
// |params| : The cast transport params.
- callback CreateParamsCallback = void (CastTransportParams params);
+ callback CreateParamsCallback = void (RtpParams params);
// Callback from the <code>getCaps</code> method.
// |caps| : Capabilities of the cast transport.
- callback GetCapsCallback = void (CastTransportCaps caps);
+ callback GetCapsCallback = void (RtpCaps caps);
interface Functions {
// Creates a cast send transport.
- // |track| : the media track encoded by this transport.
// |innerTransportId| : the ID of the inner transport. The transport to be
// created will send data on the inner transport.
+ // |track| : the media track encoded by this transport.
// |callback| : Called when the transport has been created.
[nocompile] static void create(
- [instanceOf=MediaStreamTrack] object track,
long innerTransportId,
+ [instanceOf=MediaStreamTrack] object track,
CreateCallback callback);
// Destroys a cast send transport.
@@ -105,14 +99,14 @@ namespace webrtc.castSendTransport {
// |callback| : Called when the params has been created.
[nocompile] static void createParams(
long transportId,
- CastTransportCaps remoteCaps,
+ RtpCaps remoteCaps,
CreateParamsCallback callback);
// Starts to use the transport by providing remote params info.
// |transportId| : The transport ID.
// |params| : Parameters set for this transport.
[nocompile] static void start(long transportId,
- CastTransportParams params);
+ RtpParams params);
scherkus (not reviewing) 2013/10/29 17:38:17 ditto
Alpha Left Google 2013/10/29 19:52:18 Done.
// Stops using the transport.
// |transportId| : The transport ID.
@@ -145,4 +139,3 @@ namespace webrtc.castSendTransport {
static void onError(long transportId, DOMString errorString);
};
};
-

Powered by Google App Engine
This is Rietveld 408576698