Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 473023002: Add mac_util, including MacOSXMinorVersion(), MacOSXVersion(), and MacModelAndBoard() (Closed)

Created:
6 years, 4 months ago by Mark Mentovai
Modified:
6 years, 4 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Add mac_util, including MacOSXMinorVersion(), MacOSXVersion(), and MacModelAndBoard(), along with their tests. TEST=util_test MacUtil.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/8fe32b7b9c55

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rebase #

Patch Set 3 : Improve documentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+507 lines, -0 lines) Patch
A util/mac/mac_util.h View 1 2 1 chunk +73 lines, -0 lines 0 comments Download
A util/mac/mac_util.cc View 1 chunk +282 lines, -0 lines 0 comments Download
A util/mac/mac_util_test.mm View 1 chunk +149 lines, -0 lines 0 comments Download
M util/util.gyp View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mark Mentovai
https://codereview.chromium.org/473023002/diff/1/util/mac/mac_util.h File util/mac/mac_util.h (right): https://codereview.chromium.org/473023002/diff/1/util/mac/mac_util.h#newcode27 util/mac/mac_util.h:27: //! \note This is similar to the base::mac::IsOS*() family ...
6 years, 4 months ago (2014-08-14 19:45:26 UTC) #1
Robert Sesek
LGTM https://codereview.chromium.org/473023002/diff/1/util/mac/mac_util.h File util/mac/mac_util.h (right): https://codereview.chromium.org/473023002/diff/1/util/mac/mac_util.h#newcode33 util/mac/mac_util.h:33: //! \brief Returns the version of the running ...
6 years, 4 months ago (2014-08-15 21:31:54 UTC) #2
Mark Mentovai
https://codereview.chromium.org/473023002/diff/1/util/mac/mac_util.h File util/mac/mac_util.h (right): https://codereview.chromium.org/473023002/diff/1/util/mac/mac_util.h#newcode33 util/mac/mac_util.h:33: //! \brief Returns the version of the running operating ...
6 years, 4 months ago (2014-08-16 05:30:48 UTC) #3
Mark Mentovai
6 years, 4 months ago (2014-08-16 05:33:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as 8fe32b7b9c55 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698