athena: Add a test for split-view controller.

athena: Add a test for split-view controller.

The coverage is for ActivateSplitMode() to make sure that it selects the correct
windows when at least one of the params is NULL.

BUG=383421, 403945
R=oshima@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289904

[oshima, 2014-08-14 19:52:44]

I was also working on a test for split mode (for shotcut)
and has been thinking about how to expose api. 

Give me a couple of hours and will get back to this.

[mfomitchev, 2014-08-14 22:30:21]

https://codereview.chromium.org/472963002/diff/1/athena/wm/split_view_control...
File athena/wm/split_view_controller_unittest.cc (right):

https://codereview.chromium.org/472963002/diff/1/athena/wm/split_view_control...
athena/wm/split_view_controller_unittest.cc:77: EXPECT_EQ(windows[0],
controller.right_window());
Should we also confirm that windows[0] moves to the top of the window provider
list when we do this?

https://codereview.chromium.org/472963002/diff/1/athena/wm/split_view_control...
athena/wm/split_view_controller_unittest.cc:81: EXPECT_EQ(windows[0],
controller.right_window());
Confirm windows[1] moves to the top?

https://codereview.chromium.org/472963002/diff/1/athena/wm/split_view_control...
athena/wm/split_view_controller_unittest.cc:82: }
Can you also add a test for passing two non-null windows?

[oshima, 2014-08-14 23:09:44]

My CL will take a bit more time and I don't want to block your CL, so let's move
on.

https://codereview.chromium.org/472963002/diff/1/athena/wm/split_view_control...
File athena/wm/split_view_controller.h (right):

https://codereview.chromium.org/472963002/diff/1/athena/wm/split_view_control...
athena/wm/split_view_controller.h:91: // Can be NULL (in tests).
Can you create Screen/WindowManager for now? (I'd like to avoid adding if non
null for testing)

I'll update the test base to initialize (like ash's test) so that you don't have
to do this.

[sadrul, 2014-08-15 00:20:14]

https://codereview.chromium.org/472963002/diff/1/athena/wm/split_view_control...
File athena/wm/split_view_controller.h (right):

https://codereview.chromium.org/472963002/diff/1/athena/wm/split_view_control...
athena/wm/split_view_controller.h:91: // Can be NULL (in tests).
On 2014/08/14 23:09:44, oshima wrote:
> Can you create Screen/WindowManager for now? (I'd like to avoid adding if non
> null for testing)
> 
> I'll update the test base to initialize (like ash's test) so that you don't
have
> to do this.

I have removed the need for the WindowManager from SVC in
https://codereview.chromium.org/470083004/. If that goes through, this wouldn't
be an issue anymore.

https://codereview.chromium.org/472963002/diff/1/athena/wm/split_view_control...
File athena/wm/split_view_controller_unittest.cc (right):

https://codereview.chromium.org/472963002/diff/1/athena/wm/split_view_control...
athena/wm/split_view_controller_unittest.cc:77: EXPECT_EQ(windows[0],
controller.right_window());
On 2014/08/14 22:30:20, mfomitchev wrote:
> Should we also confirm that windows[0] moves to the top of the window provider
> list when we do this?

Done.

https://codereview.chromium.org/472963002/diff/1/athena/wm/split_view_control...
athena/wm/split_view_controller_unittest.cc:81: EXPECT_EQ(windows[0],
controller.right_window());
On 2014/08/14 22:30:20, mfomitchev wrote:
> Confirm windows[1] moves to the top?

Done.

https://codereview.chromium.org/472963002/diff/1/athena/wm/split_view_control...
athena/wm/split_view_controller_unittest.cc:82: }
On 2014/08/14 22:30:20, mfomitchev wrote:
> Can you also add a test for passing two non-null windows?

Done.

[oshima, 2014-08-15 00:52:54]

lgtm

[mfomitchev, 2014-08-15 14:47:04]

https://codereview.chromium.org/472963002/diff/20001/athena/wm/split_view_con...
File athena/wm/split_view_controller_unittest.cc (right):

https://codereview.chromium.org/472963002/diff/20001/athena/wm/split_view_con...
athena/wm/split_view_controller_unittest.cc:88: EXPECT_EQ(windows[4],
*list_provider.GetWindowList().rbegin());
Do a check for the position of windows[5] in the window list as well?

[sadrul, 2014-08-15 16:27:21]

Committed patchset #3 manually as 289904 (presubmit successful).

[sadrul, 2014-08-15 16:27:46]

https://codereview.chromium.org/472963002/diff/20001/athena/wm/split_view_con...
File athena/wm/split_view_controller_unittest.cc (right):

https://codereview.chromium.org/472963002/diff/20001/athena/wm/split_view_con...
athena/wm/split_view_controller_unittest.cc:88: EXPECT_EQ(windows[4],
*list_provider.GetWindowList().rbegin());
On 2014/08/15 14:47:03, mfomitchev_OOO_Aug16-24 wrote:
> Do a check for the position of windows[5] in the window list as well?

Done.