Issue 472953002: Merged MixedDBusThreadManager functionality into DBusClientBundle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 472953002: Merged MixedDBusThreadManager functionality into DBusClientBundle. (Closed)

Created:
6 years, 4 months ago by zel

Modified:
6 years, 4 months ago

Reviewers:
hashimoto

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Part 2: Merged MixedDBusThreadManager functionality into DBusClientBundle. BUG=401192 TEST=existing tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289768

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+122 lines, -308 lines)			Patch
M	chromeos/chromeos.gyp	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chromeos/dbus/dbus_client_bundle.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chromeos/dbus/dbus_client_bundle.cc	View		6 chunks	+111 lines, -11 lines	0 comments	Download
M	chromeos/dbus/dbus_thread_manager.cc	View	1	4 chunks	+8 lines, -9 lines	0 comments	Download
D	chromeos/dbus/mixed_dbus_thread_manager.h	View		1 chunk	+0 lines, -81 lines	0 comments	Download
D	chromeos/dbus/mixed_dbus_thread_manager.cc	View		1 chunk	+0 lines, -205 lines	0 comments	Download

Total messages: 5 (0 generated)

zel

This is the first step of refactoring that I promised in https://codereview.chromium.org/444263002. The next step ...

6 years, 4 months ago (2014-08-14 19:19:03 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/472953002/20001

6 years, 4 months ago (2014-08-15 01:39:40 UTC) #4

commit-bot: I haz the power

6 years, 4 months ago (2014-08-15 03:32:07 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (20001) as 289768