Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 472933004: Change bookmark manager header to look more like settings/extensions/history. (Closed)

Created:
6 years, 4 months ago by Dan Beam
Modified:
6 years, 4 months ago
CC:
arv+watch_chromium.org, chromium-reviews, dmazzoni, hwi1, tfarina
Project:
chromium
Visibility:
Public.

Description

Change bookmark manager header to look more like settings/extensions/history. This removes the cryptic left-hand logo (that clears the search box when clicked...) and makes the title more prevalent. It also moves the search box to the opposite side of the page (e.g. right in LTR). R=arv@chromium.org BUG=405717 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291034

Patch Set 1 : tweaks #

Patch Set 2 : shave #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -42 lines) Patch
M chrome/browser/resources/bookmark_manager/css/bmm.css View 1 2 chunks +12 lines, -26 lines 0 comments Download
M chrome/browser/resources/bookmark_manager/js/main.js View 3 chunks +1 line, -11 lines 0 comments Download
M chrome/browser/resources/bookmark_manager/main.html View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Dan Beam
http://imgur.com/a/iDoR5
6 years, 4 months ago (2014-08-20 20:58:54 UTC) #1
arv (Not doing code reviews)
The bug number is not correct.
6 years, 4 months ago (2014-08-20 21:04:00 UTC) #2
Dan Beam
On 2014/08/20 21:04:00, arv wrote: > The bug number is not correct. it is; this ...
6 years, 4 months ago (2014-08-20 21:32:53 UTC) #3
Dan Beam
split out this work to http://crbug.com/405717
6 years, 4 months ago (2014-08-20 22:19:12 UTC) #4
arv (Not doing code reviews)
LGTM
6 years, 4 months ago (2014-08-20 22:26:17 UTC) #5
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 4 months ago (2014-08-20 23:42:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/472933004/60001
6 years, 4 months ago (2014-08-20 23:44:18 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-21 01:25:50 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-21 01:28:57 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/55422)
6 years, 4 months ago (2014-08-21 01:28:58 UTC) #10
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 4 months ago (2014-08-21 04:51:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/472933004/60001
6 years, 4 months ago (2014-08-21 04:52:55 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 10:01:11 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (60001) as 291034

Powered by Google App Engine
This is Rietveld 408576698