Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: tools/clang/rewrite_scoped_refptr/tests/temp-returned-as-raw-original.cc

Issue 472923002: Add logic for catching unsafe scoped_refptr conversions to T* in returns (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/rewrite_scoped_refptr/tests/temp-returned-as-raw-expected.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/rewrite_scoped_refptr/tests/temp-returned-as-raw-original.cc
diff --git a/tools/clang/rewrite_scoped_refptr/tests/temp-returned-as-raw-original.cc b/tools/clang/rewrite_scoped_refptr/tests/temp-returned-as-raw-original.cc
new file mode 100644
index 0000000000000000000000000000000000000000..e0fd791d95a6707c75b3834a8199597bcc399d15
--- /dev/null
+++ b/tools/clang/rewrite_scoped_refptr/tests/temp-returned-as-raw-original.cc
@@ -0,0 +1,22 @@
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/memory/ref_counted.h"
+
+struct Foo : public base::RefCounted<Foo> {
+ int dummy;
+};
+
+class Bar {
+ Foo* TestFunction();
+};
+
+scoped_refptr<Foo> CreateFoo();
+
+// An example of an unsafe conversion--the scoped_refptr will be destroyed by
+// the time function returns, since it's a temporary, so the returned raw
+// pointer may point to a deleted object.
+Foo* Bar::TestFunction() {
+ return CreateFoo();
+}
« no previous file with comments | « tools/clang/rewrite_scoped_refptr/tests/temp-returned-as-raw-expected.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698