tools/clang/rewrite_scoped_refptr/tests/local-returned-as-raw-expected.cc - Issue 472923002: Add logic for catching unsafe scoped_refptr conversions to T* in returns

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/rewrite_scoped_refptr/tests/local-returned-as-raw-expected.cc

Issue 472923002: Add logic for catching unsafe scoped_refptr conversions to T* in returns (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: More comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/rewrite_scoped_refptr/RewriteScopedRefptr.cpp ('k') | tools/clang/rewrite_scoped_refptr/tests/local-returned-as-raw-original.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/rewrite_scoped_refptr/tests/local-returned-as-raw-expected.cc

diff --git a/tools/clang/rewrite_scoped_refptr/tests/local-returned-as-raw-expected.cc b/tools/clang/rewrite_scoped_refptr/tests/local-returned-as-raw-expected.cc

index 340f636358736d7e0832ced232b97f3633dcf20c..30b0f8341907b15f81171be036aa3c001b569608 100644

--- a/tools/clang/rewrite_scoped_refptr/tests/local-returned-as-raw-expected.cc

+++ b/tools/clang/rewrite_scoped_refptr/tests/local-returned-as-raw-expected.cc

@@ -8,10 +8,11 @@ struct Foo {

int dummy;

};

-// Case 1: An example of an unsafe conversion, where the object is freed by

-// the time the function returns.

-Foo* GetBuggyFoo() {

+// An example of an unsafe conversion, where the object is freed by the time the

+// function returns.

+scoped_refptr<Foo> GetBuggyFoo();

+scoped_refptr<Foo> GetBuggyFoo() {

scoped_refptr<Foo> unsafe(new Foo);

- // FIXME: The tool should rewrite the return type of the function.

- return unsafe.get();

+ return unsafe;

}