Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 472893004: Apply the text autosizing multiplier in FontBuilder::updateComputedSize. (Closed)

Created:
6 years, 4 months ago by skobes
Modified:
6 years, 4 months ago
Reviewers:
pdr.
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Project:
blink
Visibility:
Public.

Description

Apply the text autosizing multiplier in FontBuilder::updateComputedSize. When we resolve style for an element with an explicit font size, we build a new FontDescription but we inherit the text autosizing multiplier from the parent's RenderStyle (see http://crbug.com/380903). We need to respect this multiplier when we initialize the computed size in the FontDescription, or else they are out of sync with each other. They remain out of sync even after we layout the element, because TextAutosizer sees that the element already has the correct multiplier and doesn't touch it. BUG=403132 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180322

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -1 line) Patch
A LayoutTests/fast/text-autosizing/inherited-multiplier.html View 1 chunk +30 lines, -0 lines 0 comments Download
A LayoutTests/fast/text-autosizing/inherited-multiplier-expected.html View 1 chunk +28 lines, -0 lines 0 comments Download
M Source/core/css/resolver/FontBuilder.cpp View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
skobes
6 years, 4 months ago (2014-08-14 19:41:34 UTC) #1
pdr.
On 2014/08/14 19:41:34, skobes wrote: LGTM, this looks great. Could you add your description of ...
6 years, 4 months ago (2014-08-14 22:16:25 UTC) #2
skobes
On 2014/08/14 22:16:25, pdr wrote: > Could you add your description of this bug (crbug.com/403132#c2) ...
6 years, 4 months ago (2014-08-14 22:27:59 UTC) #3
skobes
The CQ bit was checked by skobes@chromium.org
6 years, 4 months ago (2014-08-14 22:28:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skobes@chromium.org/472893004/1
6 years, 4 months ago (2014-08-14 22:28:29 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-15 02:11:29 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 03:09:19 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (1) as 180322

Powered by Google App Engine
This is Rietveld 408576698