Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 472843002: Use the task runner instead of MessageLoop::current() to PostTask (Closed)

Created:
6 years, 4 months ago by jkarlin
Modified:
6 years, 4 months ago
Reviewers:
michaeln, falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

When in the task runner MessageLoop::current() returns NULL. Use the task runner instead of MessageLoop::current() to PostTask. BUG=392621 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289670

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/service_worker/service_worker_cache_storage.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jkarlin
michaeln@chromium.org: Please review changes in all falken@chromium.org: Please review changes in all
6 years, 4 months ago (2014-08-14 13:55:07 UTC) #1
falken
lgtm
6 years, 4 months ago (2014-08-14 14:31:24 UTC) #2
jkarlin
The CQ bit was checked by jkarlin@chromium.org
6 years, 4 months ago (2014-08-14 14:39:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkarlin@chromium.org/472843002/1
6 years, 4 months ago (2014-08-14 14:41:09 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 19:37:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 289670

Powered by Google App Engine
This is Rietveld 408576698