Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Issue 472833002: Additional logs for supervised user auth/creation errors. (Closed)

Created:
6 years, 4 months ago by Nikita (slow)
Modified:
6 years, 4 months ago
Reviewers:
ygorshenin1
CC:
chromium-reviews, pam+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Additional logs for supervised user auth/creation errors. BUG=378338 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289797

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/chromeos/login/supervised/supervised_user_authenticator.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/login/auth/extended_authenticator.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nikita (slow)
6 years, 4 months ago (2014-08-14 12:51:20 UTC) #1
ygorshenin1
lgtm with nits. https://codereview.chromium.org/472833002/diff/1/chrome/browser/chromeos/login/supervised/supervised_user_authenticator.cc File chrome/browser/chromeos/login/supervised/supervised_user_authenticator.cc (right): https://codereview.chromium.org/472833002/diff/1/chrome/browser/chromeos/login/supervised/supervised_user_authenticator.cc#newcode266 chrome/browser/chromeos/login/supervised/supervised_user_authenticator.cc:266: LOG(ERROR) << "Failed to authenticate supervised ...
6 years, 4 months ago (2014-08-14 15:52:33 UTC) #2
Nikita (slow)
https://codereview.chromium.org/472833002/diff/1/chrome/browser/chromeos/login/supervised/supervised_user_authenticator.cc File chrome/browser/chromeos/login/supervised/supervised_user_authenticator.cc (right): https://codereview.chromium.org/472833002/diff/1/chrome/browser/chromeos/login/supervised/supervised_user_authenticator.cc#newcode266 chrome/browser/chromeos/login/supervised/supervised_user_authenticator.cc:266: LOG(ERROR) << "Failed to authenticate supervised user, code: " ...
6 years, 4 months ago (2014-08-14 16:02:06 UTC) #3
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 4 months ago (2014-08-14 16:02:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/472833002/1
6 years, 4 months ago (2014-08-14 16:06:01 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-15 04:23:05 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 05:15:06 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (1) as 289797

Powered by Google App Engine
This is Rietveld 408576698