Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: net/quic/quic_framer_test.cc

Issue 47283002: Land Recent QUIC changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix compilation error Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_framer.cc ('k') | net/quic/quic_http_stream_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_framer_test.cc
diff --git a/net/quic/quic_framer_test.cc b/net/quic/quic_framer_test.cc
index f679b81af1fdfae0e842a23acabe820f2d79819e..31c7c45d86b074d1e3f8b33249c2b2093d6e13ac 100644
--- a/net/quic/quic_framer_test.cc
+++ b/net/quic/quic_framer_test.cc
@@ -309,7 +309,7 @@ class QuicFramerTest : public ::testing::TestWithParam<QuicVersion> {
: encrypter_(new test::TestEncrypter()),
decrypter_(new test::TestDecrypter()),
start_(QuicTime::Zero().Add(QuicTime::Delta::FromMicroseconds(0x10))),
- framer_(QuicVersionMax(), start_, true) {
+ framer_(QuicSupportedVersions(), start_, true) {
version_ = GetParam();
framer_.set_version(version_);
framer_.SetDecrypter(decrypter_);
@@ -2285,9 +2285,11 @@ TEST_P(QuicFramerTest, BuildPaddingFramePacket) {
framer_.BuildUnsizedDataPacket(header, frames).packet);
ASSERT_TRUE(data != NULL);
+ // TODO(rtenneti): remove "- 16" when we remove QUIC_VERSION_10.
test::CompareCharArraysWithHexError("constructed packet",
data->data(), data->length(),
- AsChars(packet), arraysize(packet));
+ AsChars(packet),
+ arraysize(packet) - 16);
}
TEST_P(QuicFramerTest, Build4ByteSequenceNumberPaddingFramePacket) {
@@ -2331,9 +2333,11 @@ TEST_P(QuicFramerTest, Build4ByteSequenceNumberPaddingFramePacket) {
framer_.BuildUnsizedDataPacket(header, frames).packet);
ASSERT_TRUE(data != NULL);
+ // TODO(rtenneti): remove "- 16" when we remove QUIC_VERSION_10.
test::CompareCharArraysWithHexError("constructed packet",
data->data(), data->length(),
- AsChars(packet), arraysize(packet));
+ AsChars(packet),
+ arraysize(packet) - 16);
}
TEST_P(QuicFramerTest, Build2ByteSequenceNumberPaddingFramePacket) {
@@ -2377,9 +2381,11 @@ TEST_P(QuicFramerTest, Build2ByteSequenceNumberPaddingFramePacket) {
framer_.BuildUnsizedDataPacket(header, frames).packet);
ASSERT_TRUE(data != NULL);
+ // TODO(rtenneti): remove "- 16" when we remove QUIC_VERSION_10.
test::CompareCharArraysWithHexError("constructed packet",
data->data(), data->length(),
- AsChars(packet), arraysize(packet));
+ AsChars(packet),
+ arraysize(packet) - 16);
}
TEST_P(QuicFramerTest, Build1ByteSequenceNumberPaddingFramePacket) {
@@ -2423,9 +2429,11 @@ TEST_P(QuicFramerTest, Build1ByteSequenceNumberPaddingFramePacket) {
framer_.BuildUnsizedDataPacket(header, frames).packet);
ASSERT_TRUE(data != NULL);
+ // TODO(rtenneti): remove "- 16" when we remove QUIC_VERSION_10.
test::CompareCharArraysWithHexError("constructed packet",
data->data(), data->length(),
- AsChars(packet), arraysize(packet));
+ AsChars(packet),
+ arraysize(packet) - 16);
}
TEST_P(QuicFramerTest, BuildStreamFramePacket) {
« no previous file with comments | « net/quic/quic_framer.cc ('k') | net/quic/quic_http_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698