Issue 472823002: The password manager python tests now logout from websites by cleaning the cookies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 472823002: The password manager python tests now logout from websites by cleaning the cookies. (Closed)

Created:
6 years, 4 months ago by rchtara

Modified:
6 years, 4 months ago

Reviewers:
battre

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

The password manager python tests now logout from websites by cleaning the cookies. Before, in the password manager python tests, each website had its own way to logout (ex: click on a button or follow a link). This cl allows to have the same logout mechanism for all the websites thought cleaning cookies because this makes creating and maintaining tests simpler. It makes also the tests more robust. TBR=vabr@chromium.org BUG=403746 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289637

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -92 lines)			Patch
M	components/test/data/password_manager/environment.py	View		1 chunk	+17 lines, -2 lines	0 comments	Download
M	components/test/data/password_manager/tests.py	View		20 chunks	+0 lines, -88 lines	0 comments	Download
M	components/test/data/password_manager/websitetest.py	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

rchtara

Hi, Could please review the cl. PS: it's vaclav who told me it's ok to ...

6 years, 4 months ago (2014-08-14 12:55:10 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rchtara@chromium.org/472823002/20001

6 years, 4 months ago (2014-08-14 13:00:52 UTC) #4

commit-bot: I haz the power

6 years, 4 months ago (2014-08-14 17:37:06 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (20001) as 289637

Expand Messages | Collapse Messages