Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 472803002: IDL: Clean-up "should use Nullable<>" logic a little (Closed)

Created:
6 years, 4 months ago by Jens Widell
Modified:
6 years, 4 months ago
Reviewers:
haraken, bashi
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@idl-extend-IdlTypeBase
Project:
blink
Visibility:
Public.

Description

IDL: Clean-up "should use Nullable<>" logic a little Some duplication had sneaked in as part of the IDL dictionary work, with IdlTypeBase.impl_should_use_nullable_container meaning almost the same thing as IdlTypeBase.is_explicit_nullable, except the latter also implies that the type is nullable. Common up the actual logic in the new IdlTypeBase.cpp_type_has_null_value property, and use it for both impl_should_use_nullable_container and is_{implicit,explicit}_nullable. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180287

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M Source/bindings/scripts/v8_types.py View 2 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Jens Widell
bashi@: PTAL and comment on whether you think the logic is still correct for the ...
6 years, 4 months ago (2014-08-14 11:08:38 UTC) #1
bashi
On 2014/08/14 11:08:38, Jens Widell wrote: > bashi@: PTAL and comment on whether you think ...
6 years, 4 months ago (2014-08-14 13:16:06 UTC) #2
Jens Widell
On 2014/08/14 13:16:06, bashi1 wrote: > I think we can remove impl_should_use_nullable_container. I'll do it ...
6 years, 4 months ago (2014-08-14 13:24:50 UTC) #3
haraken
LGTM2
6 years, 4 months ago (2014-08-14 13:29:23 UTC) #4
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 4 months ago (2014-08-14 13:36:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/472803002/1
6 years, 4 months ago (2014-08-14 13:38:42 UTC) #6
bashi
On 2014/08/14 13:24:50, Jens Widell wrote: > On 2014/08/14 13:16:06, bashi1 wrote: > > I ...
6 years, 4 months ago (2014-08-14 13:53:31 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-14 14:42:09 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-14 14:43:57 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/16283) mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/19836) mac_gpu ...
6 years, 4 months ago (2014-08-14 14:43:58 UTC) #10
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 4 months ago (2014-08-14 15:56:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/472803002/1
6 years, 4 months ago (2014-08-14 15:57:12 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 17:32:58 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (1) as 180287

Powered by Google App Engine
This is Rietveld 408576698