Issue 472773002: Avoid using an empty scopes set when requesting an OAuth2 access token.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 472773002: Avoid using an empty scopes set when requesting an OAuth2 access token. (Closed)

Created:
6 years, 4 months ago by msarda

Modified:
6 years, 4 months ago

Reviewers:
Roger Tawa OOO till Jul 10th

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Avoid using an empty scopes set when requesting an OAuth2 access token. Usign an empty scopes set leads to a server response "code: BAD_REQUEST, http status: 400, MISSING_SCOPE" on iOS. This CL uses a non-empty scopes set for the account id tracker. BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289630

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	google_apis/gaia/account_tracker.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msarda@chromium.org/472773002/1

6 years, 4 months ago (2014-08-14 15:55:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 289630

Expand Messages | Collapse Messages