Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 472753002: Remove unused class CSSArrayFunctionValue (Closed)

Created:
6 years, 4 months ago by Timothy Loh
Modified:
6 years, 4 months ago
Reviewers:
haraken
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, blink-reviews-css, rune+blink, dglazkov+blink, dstockwell, Timothy Loh, apavlov+blink_chromium.org, rwlbuis, darktears, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@pp3
Project:
blink
Visibility:
Public.

Description

Remove unused class CSSArrayFunctionValue The class CSSArrayFunctionValue was introduced a while back for custom filters which have since been removed, so the class is now unused. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180278

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -154 lines) Patch
M Source/core/animation/animatable/AnimatableNeutralTest.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/animation/animatable/AnimatableUnknownTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D Source/core/css/CSSArrayFunctionValue.h View 1 chunk +0 lines, -63 lines 0 comments Download
D Source/core/css/CSSArrayFunctionValue.cpp View 1 chunk +0 lines, -61 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSValue.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSValue.cpp View 7 chunks +0 lines, -16 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
haraken
LGTM
6 years, 4 months ago (2014-08-14 08:07:32 UTC) #1
Timothy Loh
The CQ bit was checked by timloh@chromium.org
6 years, 4 months ago (2014-08-14 08:08:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/472753002/1
6 years, 4 months ago (2014-08-14 08:09:00 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-14 09:48:19 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-14 12:22:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/21334)
6 years, 4 months ago (2014-08-14 12:22:42 UTC) #6
Timothy Loh
The CQ bit was checked by timloh@chromium.org
6 years, 4 months ago (2014-08-14 14:26:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/472753002/1
6 years, 4 months ago (2014-08-14 14:29:13 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 16:10:35 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (1) as 180278

Powered by Google App Engine
This is Rietveld 408576698