Minor changes to allow Pepper InstancePrivate tests to pass with gin

Minor changes to allow Pepper InstancePrivate tests to pass with gin

This includes some minor changes which allow tests to when NPObject is replaced
by gin in pepper:
-Add shared library exports for use of PepperTryCatch and ScopedPPVarArray in
tests.
-Add gin as a dependency to content_unittests for use in host_var_tracker_unittest
-Change TestInstanceDeprecated so that it doesn't execute a script from the
ScriptableObject upon destruction. The reason for this is that the garbage
collector is manually run from the destructor of the plugin Instance object.
This results in destruction of the ScriptableObject and then javascript is
re-entered via ExecuteScript. This should never happen outside tests because
the garbage collector won't be run synchronously. Instead of running
ExecuteScript, which just set a variable in the Instance object to verify
that the ScriptableObject was correctly destroyed.

BUG=351636
Committed: https://chromium.googlesource.com/chromium/src/+/92c3074f4b4417924115f880657f1ec15da0e0ba

Committed: https://crrev.com/78fdb5a26f2e3cf0ed472668a48add71d043743d
Cr-Commit-Position: refs/heads/master@{#292102}

[dmichael (off chromium), 2014-08-20 17:55:53]

lgtm

https://codereview.chromium.org/472693002/diff/20001/ppapi/tests/test_instanc...
File ppapi/tests/test_instance_deprecated.cc (left):

https://codereview.chromium.org/472693002/diff/20001/ppapi/tests/test_instanc...
ppapi/tests/test_instance_deprecated.cc:59: i->instance()->AddPostCondition(
FWIW, I think this was the only usage of "AddPostCondition". We should probably
kill it off, though I don't mind if that's a separate CL.

[raymes, 2014-08-22 05:00:21]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2014-08-22 05:01:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/raymes@chromium.org/472693002/20001

[commit-bot: I haz the power, 2014-08-22 05:56:15]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[commit-bot: I haz the power, 2014-08-22 05:58:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-22 05:58:15]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[raymes, 2014-08-25 00:27:06]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2014-08-25 00:28:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/raymes@chromium.org/472693002/20001

[commit-bot: I haz the power, 2014-08-25 00:31:24]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[commit-bot: I haz the power, 2014-08-25 00:32:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-25 00:32:56]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[raymes, 2014-08-25 01:31:14]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2014-08-25 01:31:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/raymes@chromium.org/472693002/40001

[commit-bot: I haz the power, 2014-08-25 02:51:07]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-25 03:00:20]

Committed patchset #3 (40001) as 92c3074f4b4417924115f880657f1ec15da0e0ba

[Jeffrey Yasskin, 2014-08-25 22:46:42]

A revert of this CL (patchset #3) has been created in
https://codereview.chromium.org/502143003/ by jyasskin@chromium.org.

The reason for reverting is: Caused failures in DrMemory:

UNADDRESSABLE ACCESS of freed memory: writing 0x031c0278-0x031c0279 1 byte(s)
# 0 ppapi_tests.dll!`anonymous namespace'::InstanceSO::~InstanceSO            
[ppapi\tests\test_instance_deprecated.cc:48]
# 1 ppapi_tests.dll!`anonymous namespace'::InstanceSO::`scalar deleting
destructor'
# 2 ppapi_tests.dll!pp::deprecated::`anonymous namespace'::Deallocate         
[ppapi\cpp\dev\scriptable_object_deprecated.cc:126]
# 3 ppapi_proxy.dll!ppapi::CallWhileUnlocked<>                                
[ppapi\shared_impl\proxy_lock.h:123]
# 4 ppapi_proxy.dll!ppapi::proxy::PluginVarTracker::DidDeleteInstance         
[ppapi\proxy\plugin_var_tracker.cc:281]
# 5 ppapi_proxy.dll!ppapi::proxy::PPP_Instance_Proxy::OnPluginMsgDidDestroy   
[ppapi\proxy\ppp_instance_proxy.cc:194]
# 6 ppapi_proxy.dll!PpapiMsg_PPPInstance_DidDestroy::Dispatch<>               
[ppapi\proxy\ppapi_messages.h:670]
# 7 ppapi_proxy.dll!ppapi::proxy::PPP_Instance_Proxy::OnMessageReceived       
[ppapi\proxy\ppp_instance_proxy.cc:143]
# 8 ppapi_proxy.dll!ppapi::proxy::Dispatcher::OnMessageReceived               
[ppapi\proxy\dispatcher.cc:69]
# 9 ppapi_proxy.dll!ppapi::proxy::PluginDispatcher::OnMessageReceived         
[ppapi\proxy\plugin_dispatcher.cc:238]
#10 ipc.dll!IPC::ChannelProxy::Context::OnDispatchMessage                     
[ipc\ipc_channel_proxy.cc:273]
#11 ipc.dll!base::internal::Invoker<>::Run                                    
[base\bind_internal.h:1253]
#12 base.dll!base::debug::TaskAnnotator::RunTask                              
[base\debug\task_annotator.cc:62]
#13 base.dll!base::MessageLoop::RunTask                                       
[base\message_loop\message_loop.cc:436]
#14 base.dll!base::MessageLoop::DeferOrRunPendingTask                         
[base\message_loop\message_loop.cc:445]
#15 base.dll!base::MessageLoop::DoWork                                        
[base\message_loop\message_loop.cc:552]
#16 base.dll!base::MessagePumpDefault::Run                                    
[base\message_loop\message_pump_default.cc:32]
#17 base.dll!base::MessageLoop::RunHandler                                    
[base\message_loop\message_loop.cc:408]
#18 content.dll!content::PpapiPluginMain                                      
[content\ppapi_plugin\ppapi_plugin_main.cc:141]
#19 content.dll!content::RunNamedProcessTypeMain                              
[content\app\content_main_runner.cc:415]
#20 content.dll!content::ContentMainRunnerImpl::Run                           
[content\app\content_main_runner.cc:764]
#21 content.dll!content::ContentMain                                          
[content\app\content_main.cc:19]
#22 content::LaunchTests                                                      
[content\public\test\test_launcher.cc:475]
#23 main                                                                      
[content\test\content_test_launcher.cc:123]


First appeared in
http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Content%20....

[raymes, 2014-08-26 02:38:03]

Hey Dave,

I reworked the test to fix the UAF, could you take another quick look? Thanks!

Raymes

[Sam McNally, 2014-08-27 04:45:51]

sammc@chromium.org changed reviewers:
+ sammc@chromium.org

[Sam McNally, 2014-08-27 04:45:51]

lgtm

https://codereview.chromium.org/472693002/diff/60001/ppapi/tests/test_instanc...
File ppapi/tests/test_instance_deprecated.cc (right):

https://codereview.chromium.org/472693002/diff/60001/ppapi/tests/test_instanc...
ppapi/tests/test_instance_deprecated.cc:84: // This should cause the instance
objects descructor to be called.
objects descructor -> object's destructor

[raymes, 2014-08-27 05:40:34]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2014-08-27 05:41:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/raymes@chromium.org/472693002/140001

[commit-bot: I haz the power, 2014-08-27 06:41:16]

Committed patchset #8 (140001) as 8e63b40f0ee992a5cf215bc2e4a471e6d1ce34cd

[commit-bot: I haz the power, 2014-09-10 02:32:59]

Patchset 8 (id:??) landed as
https://crrev.com/41480ebd0095ac41c5b5f4e2fdbadedd8f69e041
Cr-Commit-Position: refs/heads/master@{#291636}

[commit-bot: I haz the power, 2014-09-10 02:49:53]

Patchset 8 (id:??) landed as
https://crrev.com/78fdb5a26f2e3cf0ed472668a48add71d043743d
Cr-Commit-Position: refs/heads/master@{#292102}