Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 472643002: Revert 289372 "Battery Status API: implementation for Linux." (Closed)

Created:
6 years, 4 months ago by David Trainor- moved to gerrit
Modified:
6 years, 4 months ago
Reviewers:
timvolodine
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 289372 "Battery Status API: implementation for Linux." Broke Android Tests (dbg) > Battery Status API: implementation for Linux. > > Implementation of the Battery Status API for the Linux platform. > Implementation uses DBus to talk to org.freedesktop.UPower service > to obtain battery information. > > BUG=122593 > TEST=http://jsbin.com/battery-status-test (manual) > TBR=brettw@chromium.org > NOTRY=true > > Review URL: https://codereview.chromium.org/436683002 TBR=timvolodine@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289379

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -561 lines) Patch
M trunk/src/content/browser/BUILD.gn View 1 chunk +1 line, -5 lines 0 comments Download
D trunk/src/content/browser/battery_status/battery_status_manager_linux.h View 1 chunk +0 lines, -34 lines 0 comments Download
D trunk/src/content/browser/battery_status/battery_status_manager_linux.cc View 1 chunk +0 lines, -374 lines 0 comments Download
D trunk/src/content/browser/battery_status/battery_status_manager_linux_unittest.cc View 1 chunk +0 lines, -143 lines 0 comments Download
M trunk/src/content/content_browser.gypi View 3 chunks +0 lines, -4 lines 0 comments Download
M trunk/src/content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
David Trainor- moved to gerrit
6 years, 4 months ago (2014-08-13 21:13:33 UTC) #1
David Trainor- moved to gerrit
Committed patchset #1 manually as r289379 (tree was closed).
6 years, 4 months ago (2014-08-13 21:13:56 UTC) #2
David Trainor- moved to gerrit
On 2014/08/13 21:13:56, David Trainor wrote: > Committed patchset #1 manually as r289379 (tree was ...
6 years, 4 months ago (2014-08-13 21:35:45 UTC) #3
Michael van Ouwerkerk
On 2014/08/13 21:35:45, David Trainor wrote: > On 2014/08/13 21:13:56, David Trainor wrote: > > ...
6 years, 4 months ago (2014-08-13 21:37:09 UTC) #4
David Trainor- moved to gerrit
On 2014/08/13 21:37:09, Michael van Ouwerkerk wrote: > On 2014/08/13 21:35:45, David Trainor wrote: > ...
6 years, 4 months ago (2014-08-13 21:42:33 UTC) #5
chromium-reviews
6 years, 4 months ago (2014-08-13 21:48:21 UTC) #6
Thanks David!

/m



On Wed, Aug 13, 2014 at 10:42 PM, <dtrainor@chromium.org> wrote:

> On 2014/08/13 21:37:09, Michael van Ouwerkerk wrote:
>
>> On 2014/08/13 21:35:45, David Trainor wrote:
>> > On 2014/08/13 21:13:56, David Trainor wrote:
>> > > Committed patchset #1 manually as r289379 (tree was closed).
>> >
>> > Ah sorry I meant Linux ChromiumOS Builder (dbg) was failing.
>>
>
>  Do you have a stacktrace or other kind of log?
>>
>
> http://build.chromium.org/p/chromium.chromiumos/builders/
> Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/50059/
> steps/compile/logs/stdio
>
> multiple definition of
> 'content::BatteryStatusManager::Create(base::Callback<void
> (blink::WebBatteryStatus const&)> const&)'
>
>
>
> https://codereview.chromium.org/472643002/
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698