Issue 472563002: Remove try/catch block

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 472563002: Remove try/catch block (Closed)

Created:
6 years, 4 months ago by Bo Xu

Modified:
6 years, 4 months ago

Reviewers:
Nico

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Visibility:
Public.

More Reviews

Description

Remove try/catch block BUG=pdfium:28 R=thakis@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/d4e406e

Patch Set 2 : Tabify #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+203 lines, -376 lines)			Patch
M	core/src/fxcodec/codec/fx_codec_jpx_opj.cpp	View		2 chunks	+129 lines, -139 lines	0 comments	Download
M	fpdfsdk/include/javascript/JS_Define.h	View		8 chunks	+24 lines, -100 lines	0 comments	Download
M	fpdfsdk/src/fpdf_progressive.cpp	View		1 chunk	+1 line, -8 lines	0 comments	Download
M	fpdfsdk/src/fpdftext.cpp	View		3 chunks	+8 lines, -35 lines	0 comments	Download
M	fpdfsdk/src/fpdfview.cpp	View	1	7 chunks	+24 lines, -68 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Context.cpp	View		1 chunk	+17 lines, -26 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

lgtm, thanks! I'll update the gyp file to no longer build with exceptions enabled once ...

6 years, 4 months ago (2014-08-13 17:59:31 UTC) #2

Bo Xu

Thanks! https://codereview.chromium.org/472563002/diff/1/fpdfsdk/src/fpdfview.cpp File fpdfsdk/src/fpdfview.cpp (right): https://codereview.chromium.org/472563002/diff/1/fpdfsdk/src/fpdfview.cpp#newcode277 fpdfsdk/src/fpdfview.cpp:277: if (err_code) { On 2014/08/13 17:59:31, Nico (very ...

6 years, 4 months ago (2014-08-13 18:03:00 UTC) #3

Bo Xu

6 years, 4 months ago (2014-08-13 18:03:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as d4e406e (presubmit successful).

Expand Messages | Collapse Messages

Issue 472563002: Remove try/catch block (Closed)

Description

Patch Set 1 #

Patch Set 2 : Tabify #

Messages