Allow chromium buildtools path to be overriden in the environment.

Allow chromium buildtools path to be overriden in the environment.

This is useful in certain (admittedly unsupported) cases 
when trying to use tools from depot_tools outside of a 
chrome repository.  In this particular case, I was trying 
to "git cl format" something that wasn't a chrome 
repository.

BUG=0
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=289412

[iannucci, 2014-08-13 22:44:01]

:( I have no reason to block this, but I know that it will swing around and bite
us sharply in the ass in about 6 months :(

Maybe if it had a comment like "this is completely unsupported, and will break
at a moment's notice, and the breakage will NOT be reverted", I'd be happier
about it :p

[zturner, 2014-08-13 22:47:42]

On 2014/08/13 22:44:01, iannucci wrote:
> :( I have no reason to block this, but I know that it will swing around and
bite
> us sharply in the ass in about 6 months :(
> 
> Maybe if it had a comment like "this is completely unsupported, and will break
> at a moment's notice, and the breakage will NOT be reverted", I'd be happier
> about it :p

I have no problem adding such a notice.  Will do so shortly.

[iannucci, 2014-08-13 22:56:49]

lgtm thanks :)

https://codereview.chromium.org/472553003/diff/40001/gclient_utils.py
File gclient_utils.py (right):

https://codereview.chromium.org/472553003/diff/40001/gclient_utils.py#newcode665
gclient_utils.py:665: override = os.environ['CHROMIUM_BUILDTOOLS_PATH']
os.environ.get could also work


val = os.environ.get('thingy')
if val is not None:
  return val

[zturner, 2014-08-13 22:58:37]

On 2014/08/13 22:56:49, iannucci wrote:
> lgtm thanks :)
> 
> https://codereview.chromium.org/472553003/diff/40001/gclient_utils.py
> File gclient_utils.py (right):
> 
>
https://codereview.chromium.org/472553003/diff/40001/gclient_utils.py#newcode665
> gclient_utils.py:665: override = os.environ['CHROMIUM_BUILDTOOLS_PATH']
> os.environ.get could also work
> 
> 
> val = os.environ.get('thingy')
> if val is not None:
>   return val

Thanks, that's what I was looking for.  I'm not usually a Python programmer :)

[agable, 2014-08-13 23:09:01]

On 2014/08/13 22:58:37, zturner wrote:
> On 2014/08/13 22:56:49, iannucci wrote:
> > lgtm thanks :)
> > 
> > https://codereview.chromium.org/472553003/diff/40001/gclient_utils.py
> > File gclient_utils.py (right):
> > 
> >
>
https://codereview.chromium.org/472553003/diff/40001/gclient_utils.py#newcode665
> > gclient_utils.py:665: override = os.environ['CHROMIUM_BUILDTOOLS_PATH']
> > os.environ.get could also work
> > 
> > 
> > val = os.environ.get('thingy')
> > if val is not None:
> >   return val
> 
> Thanks, that's what I was looking for.  I'm not usually a Python programmer :)

Oof yeah, this is the sort of thing that ends up abused in some obscure system
somewhere :) Thanks for adding the warning. lgtm

[zturner, 2014-08-13 23:11:36]

The CQ bit was checked by zturner@chromium.org

[commit-bot: I haz the power, 2014-08-13 23:12:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zturner@chromium.org/472553003/60001

[commit-bot: I haz the power, 2014-08-13 23:15:28]

Committed patchset #4 (60001) as 289412