Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: content/renderer/media/webcontentdecryptionmodulesession_impl.cc

Issue 472493003: Convert between |init_data_type| and content type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/webcontentdecryptionmodulesession_impl.cc
diff --git a/content/renderer/media/webcontentdecryptionmodulesession_impl.cc b/content/renderer/media/webcontentdecryptionmodulesession_impl.cc
index 65975186a5f7185310f928fec0ef84dfc9331d61..89ca4fb8a3bad8514f8d3e876f37c012ae0ab7ba 100644
--- a/content/renderer/media/webcontentdecryptionmodulesession_impl.cc
+++ b/content/renderer/media/webcontentdecryptionmodulesession_impl.cc
@@ -97,9 +97,19 @@ void WebContentDecryptionModuleSessionImpl::initializeNewSession(
}
std::string init_data_type_as_ascii = base::UTF16ToASCII(init_data_type);
- DLOG_IF(WARNING, init_data_type_as_ascii.find('/') != std::string::npos)
- << "init_data_type '" << init_data_type_as_ascii
- << "' may be a MIME type";
+
+ if (init_data_type_as_ascii.find('/') != std::string::npos) {
+ DLOG(WARNING) << "init_data_type '" << init_data_type_as_ascii
ddorwin 2014/08/13 20:59:54 IIRC, the DLOG_IF was a heads up that you may have
sandersd (OOO until July 31) 2014/08/13 21:36:19 Done.
+ << "' may be a MIME type";
+ // Attempt to translate content types.
+ // TODO(sandersd): Move to ProxyDecryptor. http://crbug.com/385874
ddorwin 2014/08/13 20:59:55 When? After converting the prefixed APIs and tests
sandersd (OOO until July 31) 2014/08/13 21:36:19 Done.
+ if (init_data_type_as_ascii == "audio/mp4" ||
ddorwin 2014/08/13 20:59:54 Use braces for this complex multi-line conditional
sandersd (OOO until July 31) 2014/08/13 21:36:19 Done.
+ init_data_type_as_ascii == "video/mp4")
+ init_data_type_as_ascii = "cenc";
+ else if (init_data_type_as_ascii == "audio/webm" ||
+ init_data_type_as_ascii == "video/webm")
+ init_data_type_as_ascii = "webm";
+ }
scoped_ptr<media::NewSessionCdmPromise> promise(
new media::NewSessionCdmPromise(

Powered by Google App Engine
This is Rietveld 408576698