DevTools: Add properties and constants support to "Documentation" module

Source/devtools/front_end/documentation/DocumentationURLProvider.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  */
 WebInspector.DocumentationURLProvider = function()
 {
 }
 
 /**
  * @const
  * @type {!Array.<{source: !Object, url: string, name: string}>}
  */
 WebInspector.DocumentationURLProvider._sources = [
     { source: window, url: "javascript/", name: "Global" },
     { source: window.Node.prototype, url: "dom/Node/", name: "Node.prototype" },
     { source: window.Node, url: "dom/Node/", name: "Node" },
     { source: window.Object.prototype, url: "javascript/Object/", name: "Object.prototype" },
     { source: window.Object, url: "javascript/Object/", name: "Object" },
     { source: window.Math, url: "javascript/Math/", name: "Math" },
     { source: window.Array.prototype, url: "javascript/Array/", name: "Array.prototype" },
     { source: window.Array, url: "javascript/Array/", name: "Array" },
     { source: window.String.prototype, url: "javascript/String/", name: "String.prototype" },
     { source: window.String, url: "javascript/String/", name: "String" },
     { source: window.Date.prototype, url: "javascript/Date/", name: "Date.prototype" },
     { source: window.Date, url: "javascript/Date/", name: "Date" },
-    { source: window.JSON, url: "javascript/JSON/", name: "JSON" }
+    { source: window.JSON, url: "javascript/JSON/", name: "JSON" },
+    { source: window.Number, url: "javascript/Number/", name: "Number"},
+    { source: window.Number.prototype, url: "javascript/Number/", name: "Number.prototype"},
+    { source: window.Error.prototype, url: "javascript/Error/", name: "Error.prototype"},
+    { source: window.RegExp.prototype, url: "javascript/RegExp/", name: "RegExp.prototype"}
 ];
 
 /**
  * @const
  */
 WebInspector.DocumentationURLProvider._urlFormat = "http://docs.webplatform.org/w/api.php?action=query&titles=%s%s&prop=revisions&rvprop=timestamp|content&format=json"
 
+/**
+ * @param {string} sourceUrl
+ * @param {string} objectName
+ * @param {string} searchTerm
+ * @return {{url: string, name: string}}
+ */
+WebInspector.DocumentationURLProvider._createProperty = function(sourceUrl, objectName, searchTerm)

[apavlov, 2014/08/13 13:35:35]

Turn this into a nested function inside itemDescriptors(), since it's only used
there. As a bonus, you won't have to pass sourceUrl and objectName, both of
which you can extract from sourceRef.

Also, let's name it "createDescriptor", since we have moved from properties to
item descriptors.

[semeny, 2014/08/13 14:10:17]

Done.

+{
+    return {
+        url: String.sprintf(WebInspector.DocumentationURLProvider._urlFormat, sourceUrl, searchTerm),
+        name: objectName
+    }

[apavlov, 2014/08/13 13:35:35]

Missing ';'

[lushnikov, 2014/08/13 13:42:15]

semicolon

[semeny, 2014/08/13 14:10:18]

Done.

+}
+
 WebInspector.DocumentationURLProvider.prototype = {
     /**
      * @param {string} searchTerm
      * @return {!Array.<{url: string, name: string}>}
      */
     itemDescriptors: function(searchTerm)
     {
         var possibleProperties = [];

[apavlov, 2014/08/13 13:35:34]

var descriptors = [];

[semeny, 2014/08/13 14:10:18]

Done.

         for (var i = 0; i < WebInspector.DocumentationURLProvider._sources.length; ++i) {
             var sourceRef = WebInspector.DocumentationURLProvider._sources[i];
-            if (sourceRef.source[searchTerm] instanceof Function) {
-                var property = {
-                    url: String.sprintf(WebInspector.DocumentationURLProvider._urlFormat, sourceRef.url, searchTerm),
-                    name: sourceRef.name
-                };
-                possibleProperties.push(property);
-            }
+            if (!(searchTerm in sourceRef.source))

[lushnikov, 2014/08/13 13:42:15]

lets use hasOwnProperty instead of "in"

[semeny, 2014/08/13 14:10:18]

Done.

+                continue;
+            if (searchTerm.toUpperCase() === searchTerm)
+                var property = WebInspector.DocumentationURLProvider._createProperty(sourceRef.url, sourceRef.name, "constants");

[apavlov, 2014/08/13 13:35:35]

We discourage multiple var declarations in conditional branches. Actually, you
can rewrite the entire snippet (from if (searchTerm...) to
possibleProperties.push) in a much shorter way (provided that we rename
possibleProperties -> descriptors):

descriptors.push(createDescriptor(searchTerm.toUpperCase() === searchTerm ?
"constants" : searchTerm));

[semeny, 2014/08/13 14:10:17]

Done.

+            else
+                var property = WebInspector.DocumentationURLProvider._createProperty(sourceRef.url, sourceRef.name, searchTerm);
+            possibleProperties.push(property);
         }
         return possibleProperties;
     }
 }