Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 472443002: Use GL_LINEAR for backing texture of offscreen framebuffer. (Closed)

Created:
6 years, 4 months ago by mazda
Modified:
6 years, 4 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use GL_LINEAR for backing texture of offscreen framebuffer. The texture filtering mode of backing texture of offscreen framebuffer is used for rendering Pepper Graphics3D contents. If GL_NEAREST is used, the contents looks bad when it is scaled (e.g. CSS transform, changing display resolution on ChromeOS). This CL changes the texture filtering mode of backing textures to GL_LINEAR to prevent the contents from looking bad in such cases. TEST=Set display resolution to 1024x680 on Pixel TEST=Apply CSS transform to NaCl emebed element TEST=Apply CSS transform to Flash content BUG=384687 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290116

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mazda
Hi piman, Could you review this change? Another option I thought about was to use ...
6 years, 4 months ago (2014-08-13 12:55:22 UTC) #1
piman
LGTM. The compositor assumes (at first) the texture it's given is GL_LINEAR. It may change ...
6 years, 4 months ago (2014-08-15 17:58:29 UTC) #2
mazda
The CQ bit was checked by mazda@chromium.org
6 years, 4 months ago (2014-08-16 03:28:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/472443002/1
6 years, 4 months ago (2014-08-16 03:29:20 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_compile_dbg on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-16 04:50:39 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-16 07:46:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 290116

Powered by Google App Engine
This is Rietveld 408576698