Issue 472403002: Prevent invalidating refresh token on transient errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 472403002: Prevent invalidating refresh token on transient errors. (Closed)

Created:
6 years, 4 months ago by pavely

Modified:
6 years, 4 months ago

Reviewers:
Roger Tawa OOO till Jul 10th, Nicolas Zea

CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org, Nikita (slow)

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Prevent invalidating refresh token on transient errors. Problem: When access token request fails with unexpected errors those get translated to "invalid credentials". In response auth_sync_observer.cc marks refresh token as invalid which prevents offline auth on next startup. oauth2_access_token_fetcher_impl.cc: - Handle all 5xx http codes as transient errors. - Log error for unexpected codes. profile_sync_service.cc: - handle REQUEST_CANCELLED and SERVICE_ERROR as transient error, retry instead of notifying observers. - Log error for unexpected auth errors. BUG=394939 R=rogerta@chromium.org,zea@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290158

Patch Set 1 #

Patch Set 2 : Fix integration tests #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -16 lines)			Patch
M	chrome/browser/sync/profile_sync_service.cc	View		3 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/sync/test/integration/sync_auth_test.cc	View	1	3 chunks	+7 lines, -9 lines	0 comments	Download
M	google_apis/gaia/oauth2_access_token_fetcher_impl.cc	View		2 chunks	+14 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/472403002/20001

6 years, 4 months ago (2014-08-16 17:11:42 UTC) #5

commit-bot: I haz the power

6 years, 4 months ago (2014-08-16 20:47:13 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (20001) as 290158

Expand Messages | Collapse Messages