Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 472373006: Change type of drag-drop window to popup (Closed)

Created:
6 years, 4 months ago by mohsen
Modified:
6 years, 4 months ago
Reviewers:
sky
CC:
ben+ash_chromium.org, chromium-reviews, dcheng, kalyank, sadrul
Project:
chromium
Visibility:
Public.

Description

Change type of drag-drop window to popup Currently, the window for drag-drop is a normal window. This is not right and cuases a few issues (e.g. see crbug.com/404634). This patch changes the type to popup. BUG=404634 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290753

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ash/drag_drop/drag_drop_tracker.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
mohsen
Please take a look...
6 years, 4 months ago (2014-08-19 21:13:48 UTC) #1
sky
LGTM https://codereview.chromium.org/472373006/diff/1/ash/drag_drop/drag_drop_tracker.cc File ash/drag_drop/drag_drop_tracker.cc (right): https://codereview.chromium.org/472373006/diff/1/ash/drag_drop/drag_drop_tracker.cc#newcode45 ash/drag_drop/drag_drop_tracker.cc:45: window->SetType(ui::wm::WINDOW_TYPE_POPUP); Add a comment as to why popup ...
6 years, 4 months ago (2014-08-19 22:05:48 UTC) #2
mohsen
https://codereview.chromium.org/472373006/diff/1/ash/drag_drop/drag_drop_tracker.cc File ash/drag_drop/drag_drop_tracker.cc (right): https://codereview.chromium.org/472373006/diff/1/ash/drag_drop/drag_drop_tracker.cc#newcode45 ash/drag_drop/drag_drop_tracker.cc:45: window->SetType(ui::wm::WINDOW_TYPE_POPUP); On 2014/08/19 22:05:48, sky wrote: > Add a ...
6 years, 4 months ago (2014-08-20 00:58:56 UTC) #3
mohsen
The CQ bit was checked by mohsen@chromium.org
6 years, 4 months ago (2014-08-20 00:59:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/472373006/60001
6 years, 4 months ago (2014-08-20 00:59:30 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 04:01:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (60001) as 290753

Powered by Google App Engine
This is Rietveld 408576698