Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: pkg/analysis_server/tool/spec/spec_input.html

Issue 472373002: Support potential edits (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/integration/protocol_matchers.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/tool/spec/spec_input.html
diff --git a/pkg/analysis_server/tool/spec/spec_input.html b/pkg/analysis_server/tool/spec/spec_input.html
index 48c23cc53dfb25f4a87cd3c440aa165c734b391c..fa371f70ece779d574d2120ae133403c0a013365 100644
--- a/pkg/analysis_server/tool/spec/spec_input.html
+++ b/pkg/analysis_server/tool/spec/spec_input.html
@@ -1238,12 +1238,24 @@
<p>
The changes that are to be applied to affect the
refactoring. This field will be omitted if there are
- problems that prevent a set of changed from being
+ problems that prevent a set of changes from being
computed, such as having no options specified for a
refactoring that requires them, or if only validation
was requested.
</p>
</field>
+ <field name="potentialChanges" optional="true">
scheglov 2014/08/15 18:38:35 "potentialEdits"?
Brian Wilkerson 2014/08/15 18:44:24 I chose the name to be consistent with the 'change
+ <list><ref>String</ref></list>
+ <p>
+ The ids of source edits that are not known to be valid. An edit is
+ not known to be valid if there was insufficient type information
+ for the server to be able to determine whether or not the code
+ needs to be modified, such as when a member is being renamed and
+ there is a reference to a member from an unknown type. This field
+ will be omitted if the change field is omitted or if there are no
+ potential edits for the refactoring.
+ </p>
+ </field>
</result>
</request>
</domain>
@@ -2711,6 +2723,22 @@
original code.
</p>
</field>
+ <field name="id" optional="true">
+ <ref>String</ref>
+ <p>
+ An identifier that uniquely identifies this source edit from other
+ edits in the same response. This field is omitted unless a
+ containing structure needs to be able to identify the edit for
+ some reason.
+ </p>
+ <p>
+ For example, some refactoring operations can produce edits that
+ might not be appropriate (referred to as potential edits). Such
+ edits will have an id so that they can be referenced. Edits in
+ the same response that do not need to be referenced will not have
+ an id.
+ </p>
+ </field>
</object>
</type>
<type name="SourceFileEdit">
« no previous file with comments | « pkg/analysis_server/test/integration/protocol_matchers.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698