Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 472353002: DevTools: Get rid of WebInspector.PresentationMessage interface (Closed)

Created:
6 years, 4 months ago by apavlov
Modified:
6 years, 4 months ago
Reviewers:
eustas, vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Get rid of WebInspector.PresentationMessage interface The PresentationConsoleMessage management is moved from UISourceCode into PresentationConsoleMessageHelper. R=eustas, vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180442

Patch Set 1 #

Total comments: 2

Patch Set 2 : Clear event targets map and handle ProjectRemoved #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -60 lines) Patch
M Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js View 1 2 chunks +15 lines, -0 lines 0 comments Download
M Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js View 1 6 chunks +134 lines, -10 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/JavaScriptSourceFrame.js View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/devtools/front_end/workspace/UISourceCode.js View 3 chunks +3 lines, -42 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
apavlov
6 years, 4 months ago (2014-08-15 17:18:17 UTC) #1
apavlov
https://codereview.chromium.org/472353002/diff/1/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js File Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js (right): https://codereview.chromium.org/472353002/diff/1/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js#newcode49 Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js:49: this._uiSourceCodeToEventTarget = new Map(); This thing is never cleared.
6 years, 4 months ago (2014-08-17 21:32:06 UTC) #2
vsevik
https://codereview.chromium.org/472353002/diff/1/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js File Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js (right): https://codereview.chromium.org/472353002/diff/1/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js#newcode49 Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js:49: this._uiSourceCodeToEventTarget = new Map(); It should be!
6 years, 4 months ago (2014-08-18 05:53:07 UTC) #3
apavlov
On 2014/08/18 05:53:07, vsevik wrote: > https://codereview.chromium.org/472353002/diff/1/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js > File Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js > (right): > > https://codereview.chromium.org/472353002/diff/1/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js#newcode49 ...
6 years, 4 months ago (2014-08-18 09:34:58 UTC) #4
vsevik
lgtm
6 years, 4 months ago (2014-08-18 09:47:39 UTC) #5
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 4 months ago (2014-08-18 09:48:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/472353002/20001
6 years, 4 months ago (2014-08-18 09:48:52 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 10:49:02 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (20001) as 180442

Powered by Google App Engine
This is Rietveld 408576698